[foreign-memaccess+abi] RFR: Modernize code [v3]

[Maurizio Cimadamore]

On Mon, 25 Sep 2023 07:59:26 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR proposes to modernize some parts of the code with constructs from newer Java versions.
>
> Per Minborg has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Rename and reformat
>  - Use allocation free constructs

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 569:

> 567: 
> 568:     private static int getScaleFactor(Buffer buffer) {
> 569:         return switch (buffer) {

sorry, this is, I think, buggy. Note that you can have an IntBuffer wrapped around a byte[], in which case the calculation will misfire. I think the factory using this method should just call BaseAndScale::of (on the heap array) and then get the scale from there.

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 704:

> 702:     }
> 703: 
> 704:     record BaseAndScale(int base, long scale) {

This is very nice. Perhaps we could consider moving this to Util

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/894#discussion_r1335548533
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/894#discussion_r1335549419