[foreign-memaccess+abi] RFR: Fix visibility issues

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Sep 25 08:42:44 UTC 2023


On Mon, 25 Sep 2023 08:31:53 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> > Not super sure about this?
> 
> It appears difficult to contain the use of the classes that are changed to `public` as they are used from several packages. It might be possible but, I am not sure if it is worth the effort?

I think that in this particular case I don't see a lot of benefit changing the code one way or another as all the classes are in non-exported packages anyway. So one could argue that "public" doesn't really mean public, or, on the other hand, also argue that exposing a non-public interface in a public method (which isn't really public) isn't a big deal (even though the IDE might mark that with a squiggly line). This is not public API, so I'm not sure how much these warnings are important to fix.

-------------

PR Comment: https://git.openjdk.org/panama-foreign/pull/891#issuecomment-1733182602


More information about the panama-dev mailing list