[foreign-memaccess+abi] RFR: Modernize code [v5]

[Maurizio Cimadamore]

On Mon, 25 Sep 2023 10:52:09 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'foreign-memaccess+abi' into modernize-code
>>  - Remove the use of Unsafe
>>  - Rename and reformat
>>  - Use allocation free constructs
>>  - Improve switch and use record for return type
>>  - Modernize code
>
> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 545:
> 
>> 543:             return switch (base) {
>> 544:                 case byte[] __ ->
>> 545:                         new HeapMemorySegmentImpl.OfByte(bbAddress + (pos << scaleFactor), base, size << scaleFactor, readOnly, bufferScope);
> 
> Actually, I think this logic is not correct...

NVM, got confused by the diff - getScaleFactor is still there (I thought it was removed)

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/894#discussion_r1335722428