[foreign-memaccess+abi] RFR: Refresh FFM documents [v3]

Jorn Vernee jvernee at openjdk.org
Wed Jan 10 14:51:08 UTC 2024


On Wed, 10 Jan 2024 14:47:48 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR brings the FFM documents in sync with the finalized API in JDK 22. The most obvious changes are:
>> 
>> * in the foreign memory document, the section on structured access has been rectified, to take into account the extra offset parameter that is added to memory access var handles;
>> * in both documents, several calls to `allocateArray` and `allocateUtf8String` have been replaced with `allocateFrom`
>> * the section introducing the `Linker` in the ffi document has been revamped; it now talks more at length about the mapping between layouts and C types. The table with Linux/x64 mappings has been moved to a section in the appendix, and I have also added a mention of `Linker::canonicalLayouts`
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Marked as reviewed by jvernee (Committer).

doc/panama_ffi.md line 98:

> 96: ```
> 97: 
> 98: For a more exhaustive examples of mappings between C types and layouts, please refer to the [appendix](#c-types-mapping-in-linuxx64). In the following sections, we will assume Linux/x64 as our target platform.

Suggestion:

For more exhaustive examples of mappings between C types and layouts, please refer to the [appendix](#c-types-mapping-in-linuxx64). In the following sections, we will assume Linux/x64 as our target platform.

-------------

PR Review: https://git.openjdk.org/panama-foreign/pull/914#pullrequestreview-1813395951
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/914#discussion_r1447485139


More information about the panama-dev mailing list