[vectorIntrinsics] RFR: 8343779: Cannot build Vector API JMH benchmarks on vectorIntrinsics branch

Paul Sandoz psandoz at openjdk.org
Thu Nov 14 00:38:07 UTC 2024


On Mon, 11 Nov 2024 15:59:51 GMT, Mikhail Ablakatov <duke at openjdk.org> wrote:

> To generate pseudo-random values, the benchmarks mostly reference the
> Random RAND object. However, occasionally RANDOM is referenced instead
> of RAND. The mismatch causes build errors.
> 
> Reference RAND across Vector API JMH benchmarks consistently.

Thank you for looking at this. This area has obviously bit rotted.

Many of these classes are generated from templates. You need to modify the templates and run the generation script instead of modifying directly.

See https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/test/jdk/jdk/incubator/vector/README.md
and https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/test/jdk/jdk/incubator/vector/BENCHMARKS.md for details.

See https://github.com/openjdk/panama-vector/tree/vectorIntrinsics/test/jdk/jdk/incubator/vector/templates for the perf-related templates (specifically Perf-Scalar-header.template and Perf-header.template).

Other non-template generated benchmarks also require updating due to additional compiler warnings (which are configured to be errors), specifically about lossy numerical conversion. (See VectorDistance.java, ChaChaBench.java, and Poly1305Bench.java)

-------------

PR Comment: https://git.openjdk.org/panama-vector/pull/221#issuecomment-2475107893


More information about the panama-dev mailing list