[vectorIntrinsics] RFR: 8343779: Cannot build Vector API JMH benchmarks on vectorIntrinsics branch [v2]
Paul Sandoz
psandoz at openjdk.org
Thu Nov 21 01:13:46 UTC 2024
On Wed, 20 Nov 2024 11:02:25 GMT, Mikhail Ablakatov <duke at openjdk.org> wrote:
>> To generate pseudo-random values, the benchmarks mostly reference the
>> Random RAND object. However, occasionally RANDOM is referenced instead
>> of RAND. The mismatch causes build errors. Reference RAND across Vector
>> API JMH benchmarks consistently.
>>
>> Some benchmarks fail to build due to lossy-conversion compiler warnings
>> which are configured to be errors. Fix narrowing numerical conversions.
>
> Mikhail Ablakatov has updated the pull request incrementally with one additional commit since the last revision:
>
> Reflect RANDOM changes in templates; fix lossy-conversion warnings
>
> Some benchmarks fail to build due to lossy-conversion compiler warnings
> which are configured to be errors. Fix narrowing numerical conversions.
Marked as reviewed by psandoz (Committer).
-------------
PR Review: https://git.openjdk.org/panama-vector/pull/221#pullrequestreview-2450019294
More information about the panama-dev
mailing list