[vectorIntrinsics] RFR: 8343689: AArch64: Optimize MulReduction implementation
Andrew Haley
aph at openjdk.org
Thu Jan 16 17:28:12 UTC 2025
On Thu, 16 Jan 2025 16:51:14 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> >
> > Oh, please let's have them in mainline. It's a PITA for reviewers not to be able to see them. What's the downside?
>
> In the past we have been reluctant to add the generated benchmarks ([here](https://github.com/openjdk/panama-vector/tree/vectorIntrinsics/test/micro/org/openjdk/bench/jdk/incubator/vector/operation)) due to the quantity of them (the scripts would also need to be included) and whether this was the right approach.
I see. OK, in that case please let's make it easy for reviewers to find them. Last time I reviewed any of this stuff it took me quite a while to find and run the benchmarks that were in a different tree.
I don't want to make work for anyone, but would a script in "devkit/get-panama-benchmarks", followed by the usual "make build-microbenchmark" make life easier for all?
-------------
PR Comment: https://git.openjdk.org/panama-vector/pull/225#issuecomment-2596302677
More information about the panama-dev
mailing list