<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">
<div>Here it is:</div>
<div><br>
</div>
https://bugs.openjdk.org/browse/JDK-8314544<br>
<div><br>
</div>
<div>Paul.</div>
<div><br>
<blockquote type="cite">
<div>On Aug 17, 2023, at 11:37 AM, Martin Stypinski <mstypinski@gmail.com> wrote:</div>
<br class="Apple-interchange-newline">
<div>
<div dir="ltr">OK, so can you open an issue and send me the number? I can redo the PR next week.
<div><br>
</div>
<div>Best</div>
<div>Martin.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Am Do., 17. Aug. 2023 um 18:57 Uhr schrieb Paul Sandoz <<a href="mailto:paul.sandoz@oracle.com">paul.sandoz@oracle.com</a>>:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>Thanks, part of step 3 is I need create an issue and associate it with the PR. (There are some failed pre-integration checks that block integration and this is one of them)
<div><br>
</div>
<div>Paul.<br>
<div><br>
<blockquote type="cite">
<div>On Aug 17, 2023, at 3:12 AM, Martin Stypinski <<a href="mailto:mstypinski@gmail.com" target="_blank">mstypinski@gmail.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">ok, fixed it as discussed
<div><br>
</div>
<div>1. is done - a long time ago.</div>
<div>2. PR is done, testing went through</div>
<div>3. Go ahead</div>
<div><br>
</div>
<div>Any reasons why it failed?</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Am Mi., 16. Aug. 2023 um 23:01 Uhr schrieb Paul Sandoz <<a href="mailto:paul.sandoz@oracle.com" target="_blank">paul.sandoz@oracle.com</a>>:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>That looks good. I recommend:
<div><br>
</div>
<div>- Removing the system property for <span>VECTOR_ACCESS_OOB_CHECK</span></div>
<div>- The benchmark methods should return the result (JMH will send it down a blackhole) <br>
<div>- You may also want to remove the allocation of the result matrix (pass it in as a pre-allocated argument and return it), since what we are interested here is how this all optimizes for the loop structure.</div>
<div><br>
</div>
<div>The process is:</div>
<div><br>
</div>
<div>1. Sign the OCA <a href="https://oca.opensource.oracle.com/" target="_blank">
https://oca.opensource.oracle.com/</a></div>
<div>2. Submit a PR to <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/__;!!ACWV5N9M2RV99hQ!I32aHuZI7cW86Y3E969ZLyt4xH5nc2970bNrLwvfU1kc_rvxq1863brm4DAQrlmUr8XbLIuCX__gW28g2LC-$" target="_blank">https://github.com/openjdk/jdk/</a>, placing
the class in test/micro/org/openjdk/bench/jdk/incubator/vector/</div>
<div>(Building the JDK and testing should be straightforward, for testing see <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/blob/master/doc/testing.md__;!!ACWV5N9M2RV99hQ!I32aHuZI7cW86Y3E969ZLyt4xH5nc2970bNrLwvfU1kc_rvxq1863brm4DAQrlmUr8XbLIuCX__gW0i3Z52N$" target="_blank">https://github.com/openjdk/jdk/blob/master/doc/testing.md</a>)</div>
<div>3. I can review/sponsor</div>
<div><br>
</div>
<div>Paul.</div>
<div> <br>
<blockquote type="cite">
<div>On Aug 11, 2023, at 12:24 AM, Martin Stypinski <<a href="mailto:mstypinski@gmail.com" target="_blank">mstypinski@gmail.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">
<div>Hi all,</div>
<div><br>
</div>
<div>I started this thing a long time ago and wanted to actually contribute my matrix benchmark as suggested by Paul. I made some changes:
<a href="https://urldefense.com/v3/__https://gist.github.com/Styp/618cf9d139151727f46396235aff09a3__;!!ACWV5N9M2RV99hQ!I32aHuZI7cW86Y3E969ZLyt4xH5nc2970bNrLwvfU1kc_rvxq1863brm4DAQrlmUr8XbLIuCX__gW7I6h23g$" target="_blank">
https://gist.github.com/Styp/618cf9d139151727f46396235aff09a3</a></div>
<div><br>
</div>
<div>Paul; What do you think? And how does the process work?</div>
<div><br>
</div>
<div>Best</div>
<div>Martin<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br>
</body>
</html>