From zhangshj at linux.vnet.ibm.com Tue Jul 3 00:44:31 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Tue, 03 Jul 2012 07:44:31 +0000 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. Message-ID: <20120703074432.4203547C5E@hg.openjdk.java.net> Changeset: 39373c36d5e6 Author: Shi Jun Zhang Date: 2012-07-03 15:43 +0800 URL: http://hg.openjdk.java.net/penrose/penrose/rev/39373c36d5e6 1. Update Penrose demos to support JSON format module info. 2. Update modulebrowser demo to avoid NPE. ! demo/classloader/README ! demo/classloader/build.sh + demo/classloader/src/classloader/META-INF/module-info.json + demo/classloader/src/foo/META-INF/module-info.json ! demo/java2d/README + demo/java2d/src/resource/java2d.demos.arcs/META-INF/module-info.json + demo/java2d/src/resource/java2d.demos.clipping/META-INF/module-info.json + demo/java2d/src/resource/java2d.demos/META-INF/module-info.json ! demo/modulebrowser/build.sh + demo/modulebrowser/src/META-INF/module-info.json ! demo/modulebrowser/src/demo/modulebrowser/LibraryNode.java ! demo/modulebrowser/src/demo/modulebrowser/ModuleNode.java ! demo/modulebrowser/src/demo/modulebrowser/RequiresNode.java From zhangshj at linux.vnet.ibm.com Tue Jul 3 01:23:29 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Tue, 03 Jul 2012 08:23:29 +0000 Subject: hg: penrose/jigsaw/jdk: 7 new changesets Message-ID: <20120703082510.E4BCF47C60@hg.openjdk.java.net> Changeset: 2bb67319c588 Author: psandoz Date: 2012-06-14 17:10 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/2bb67319c588 jdk.tools.jaxws missing requires service com.sun.tools.internal.xjc.Plugin ! make/modules/jdk.depconfig Changeset: 29e9f2da3338 Author: alanb Date: 2012-06-20 16:31 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/29e9f2da3338 Swing Look and Feels should be exported ! make/modules/modules.group Changeset: c2c4b5425238 Author: alanb Date: 2012-06-21 21:27 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/c2c4b5425238 Service declarations for JAXP ! make/modules/jdk.depconfig Changeset: 99f164e91346 Author: psandoz Date: 2012-06-22 19:32 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/99f164e91346 ServiceLoader updates - list of service provider modules is now global in configuration - restore ServiceLoaer.load methods (remove hacks) ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/org/openjdk/jigsaw/Configuration.java ! src/share/classes/org/openjdk/jigsaw/Context.java ! src/share/classes/org/openjdk/jigsaw/Linker.java ! src/share/classes/org/openjdk/jigsaw/Loader.java ! src/share/classes/org/openjdk/jigsaw/LoaderPool.java + src/share/classes/org/openjdk/jigsaw/ModuleServiceLoader.java ! src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java ! src/share/native/common/jigsaw.c + test/org/openjdk/jigsaw/services/classloader.sh Changeset: 3ade388252f8 Author: mchung Date: 2012-06-27 18:12 -0700 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/3ade388252f8 Implement a proper check to determine if getClassLoader permission is required Reviewed-by: alanb, dholmes, psandoz ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! test/org/openjdk/jigsaw/security.sh Changeset: d11cc59f4daf Author: chegar Date: 2012-06-28 18:05 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/d11cc59f4daf Add module file parser API Reviewed-by: psandoz, alanb, mullan ! make/java/java/FILES_java.gmk ! src/share/classes/org/openjdk/jigsaw/Library.java ! src/share/classes/org/openjdk/jigsaw/ModuleFile.java + src/share/classes/org/openjdk/jigsaw/ModuleFileParser.java + src/share/classes/org/openjdk/jigsaw/ModuleFileParserDelegate.java + src/share/classes/org/openjdk/jigsaw/ModuleFileParserException.java + src/share/classes/org/openjdk/jigsaw/ModuleFileParserImpl.java ! src/share/classes/org/openjdk/jigsaw/ModuleFileWriter.java ! src/share/classes/org/openjdk/jigsaw/SignedModule.java ! src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java + src/share/classes/org/openjdk/jigsaw/ValidatingModuleFileParser.java + src/share/classes/org/openjdk/jigsaw/ValidatingModuleFileParserImpl.java ! src/share/classes/org/openjdk/jigsaw/cli/Librarian.java ! src/share/classes/org/openjdk/jigsaw/cli/Signer.java ! test/org/openjdk/jigsaw/cli/ModuleFormatTestLeftOverBytes.java Changeset: 9a30eba3b4fa Author: Shi Jun Zhang Date: 2012-07-03 16:22 +0800 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/9a30eba3b4fa Merge ! make/java/java/FILES_java.gmk ! src/share/classes/org/openjdk/jigsaw/Library.java ! src/share/classes/org/openjdk/jigsaw/Loader.java ! src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java From zhangshj at linux.vnet.ibm.com Tue Jul 3 01:28:16 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Tue, 03 Jul 2012 08:28:16 +0000 Subject: hg: penrose/jigsaw: 2 new changesets Message-ID: <20120703082816.A023C47C61@hg.openjdk.java.net> Changeset: c5f8b970c983 Author: michaelm Date: 2012-06-14 16:55 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/rev/c5f8b970c983 Initial load of scripts to support source code shuffle/unshuffle + make/scripts/shuffle/CheckNative.java + make/scripts/shuffle/Compare.java + make/scripts/shuffle/README + make/scripts/shuffle/Reverse.java + make/scripts/shuffle/docompare + make/scripts/shuffle/getdifferences + make/scripts/shuffle/jdk.base.includes + make/scripts/shuffle/jdk.corba.includes + make/scripts/shuffle/jdk.desktop.includes + make/scripts/shuffle/jdk.jaxp.includes + make/scripts/shuffle/jdk.jaxws.includes + make/scripts/shuffle/jdk.jaxws.tools.includes + make/scripts/shuffle/jdk.jdbc.includes + make/scripts/shuffle/jdk.jx.annotations.includes + make/scripts/shuffle/jdk.scripting.includes + make/scripts/shuffle/jdk.tools.includes + make/scripts/shuffle/makeshufflescripts + make/scripts/shuffle/moduleinfo.others/classlist/jdk.auth.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.base.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.compat.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.compiler.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.corba.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.cosnaming.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.crypto.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.deploy.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.desktop.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.devtools.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.httpserver.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.instrument.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jaxp.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jaxws.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jdbc.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jdbc.rowset.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jndi.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jta.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.jx.annotations.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.kerberos.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.logging.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.management.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.management.iiop.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.prefs.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.rmi.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.scripting.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.sctp.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.security.acl.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.smartcardio.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.snmp.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.sunec.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.sunmscapi.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.sunpkcs11.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.tls.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.tools.base.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.tools.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.tools.jaxws.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.tools.jre.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.ucrypto.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.xmldsig.classlist + make/scripts/shuffle/moduleinfo.others/classlist/jdk.zipfs.classlist + make/scripts/shuffle/moduleinfo.others/classlist/sun.charsets.classlist + make/scripts/shuffle/moduleinfo.others/classlist/sun.localedata.classlist + make/scripts/shuffle/moduleinfo.others/classlist/sun.resources.classlist + make/scripts/shuffle/moduleinfo.others/shuffledata/native.dirs + make/scripts/shuffle/non-standard.includes + make/scripts/shuffle/shuffle.sh + make/scripts/shuffle/sun.localedata.includes + make/scripts/shuffle/unshuffle.sh + make/scripts/shuffle/zipfs.shuffle + make/scripts/shuffle/zipfs.unshuffle Changeset: fe2cf8de1297 Author: michaelm Date: 2012-06-22 14:08 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/rev/fe2cf8de1297 Source code shuffle should copy module-info sources into place ! make/scripts/shuffle/makeshufflescripts From zhangshj at linux.vnet.ibm.com Tue Jul 3 01:31:33 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Tue, 03 Jul 2012 08:31:33 +0000 Subject: hg: penrose/jigsaw/bdb: Support building BDB on ppc Message-ID: <20120703083133.E4D6047C62@hg.openjdk.java.net> Changeset: 8ff6e91a0455 Author: dholmes Date: 2012-06-26 14:32 +0100 URL: http://hg.openjdk.java.net/penrose/jigsaw/bdb/rev/8ff6e91a0455 Support building BDB on ppc Reviewed-by: chegar ! make/Makefile From zhangshj at linux.vnet.ibm.com Tue Jul 3 23:36:42 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Wed, 04 Jul 2012 14:36:42 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <20120703074432.4203547C5E@hg.openjdk.java.net> References: <20120703074432.4203547C5E@hg.openjdk.java.net> Message-ID: <4FF3E47A.9080206@linux.vnet.ibm.com> On 7/3/2012 3:44 PM, zhangshj at linux.vnet.ibm.com wrote: > Changeset: 39373c36d5e6 > Author: Shi Jun Zhang > Date: 2012-07-03 15:43 +0800 > URL: http://hg.openjdk.java.net/penrose/penrose/rev/39373c36d5e6 > > 1. Update Penrose demos to support JSON format module info. > 2. Update modulebrowser demo to avoid NPE. > > ! demo/classloader/README > ! demo/classloader/build.sh > + demo/classloader/src/classloader/META-INF/module-info.json > + demo/classloader/src/foo/META-INF/module-info.json > ! demo/java2d/README > + demo/java2d/src/resource/java2d.demos.arcs/META-INF/module-info.json > + demo/java2d/src/resource/java2d.demos.clipping/META-INF/module-info.json > + demo/java2d/src/resource/java2d.demos/META-INF/module-info.json > ! demo/modulebrowser/build.sh > + demo/modulebrowser/src/META-INF/module-info.json > ! demo/modulebrowser/src/demo/modulebrowser/LibraryNode.java > ! demo/modulebrowser/src/demo/modulebrowser/ModuleNode.java > ! demo/modulebrowser/src/demo/modulebrowser/RequiresNode.java > Some issues I find when updating the demos to support JSON format module info. 1. We need to add some document on how to write JSON format module info. I have to look into source code to learn how module-info.json structures and how to add modifiers. 2. Error message is not clear enough. I typed "jdk.desktip" by mistake in requires section in modulebrowser, and then I got an error said "modulebrowser cannot be solved" when installing the module into module library. It should tell "jdk.desktip cannot be solved" instead. -- Regards, Shi Jun Zhang From zhangshj at linux.vnet.ibm.com Tue Jul 3 23:43:03 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Wed, 04 Jul 2012 14:43:03 +0800 Subject: The state of the penrose web pages/wiki In-Reply-To: <4FB64DC4.4070807@oracle.com> References: <4FB3CA87.1070105@oracle.com> <4FB64636.1020401@oracle.com> <4FB64DC4.4070807@oracle.com> Message-ID: <4FF3E5F7.3030105@linux.vnet.ibm.com> On 5/18/2012 9:25 PM, Dalibor Topic wrote: > On 5/18/12 3:06 PM, David Bosschaert wrote: >> Thanks Dalibor - Yes, that would help :) >> > OK - page updated. > > cheers, > dalibor topic Hi Dalibor, Could you help to add penrose-discuss mailing list on the Penrose project page? It's under the 3-clause BSD license and also GPLv2. -- Regards, Shi Jun Zhang From david.bosschaert at gmail.com Wed Jul 4 04:04:54 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Wed, 4 Jul 2012 12:04:54 +0100 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <4FF3E47A.9080206@linux.vnet.ibm.com> References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> Message-ID: On 4 July 2012 07:36, Shi Jun Zhang wrote: > On 7/3/2012 3:44 PM, zhangshj at linux.vnet.ibm.com wrote: >> >> Changeset: 39373c36d5e6 >> Author: Shi Jun Zhang >> Date: 2012-07-03 15:43 +0800 >> URL: http://hg.openjdk.java.net/penrose/penrose/rev/39373c36d5e6 >> >> 1. Update Penrose demos to support JSON format module info. >> 2. Update modulebrowser demo to avoid NPE. >> >> ! demo/classloader/README >> ! demo/classloader/build.sh >> + demo/classloader/src/classloader/META-INF/module-info.json >> + demo/classloader/src/foo/META-INF/module-info.json >> ! demo/java2d/README >> + demo/java2d/src/resource/java2d.demos.arcs/META-INF/module-info.json >> + demo/java2d/src/resource/java2d.demos.clipping/META-INF/module-info.json >> + demo/java2d/src/resource/java2d.demos/META-INF/module-info.json >> ! demo/modulebrowser/build.sh >> + demo/modulebrowser/src/META-INF/module-info.json >> ! demo/modulebrowser/src/demo/modulebrowser/LibraryNode.java >> ! demo/modulebrowser/src/demo/modulebrowser/ModuleNode.java >> ! demo/modulebrowser/src/demo/modulebrowser/RequiresNode.java >> Great stuff, Shi Jun! I think we should also remove the module-info.java files. If there's anything that you're finding that isn't working with purely module-info.json files please let me know and I'll look into it. > Some issues I find when updating the demos to support JSON format module > info. > > 1. We need to add some document on how to write JSON format module info. I > have to look into source code to learn how module-info.json structures and > how to add modifiers. Yes, this is correct. It would be great if we had a wiki to host this information. But in the absence of that I'll create a document and will share it some other way. Currently there are 2 system tests that can be used as example: * http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/507fae0a1d80/test/org/openjdk/jigsaw/hello-json.sh * http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/1d2576346081/test/org/openjdk/jigsaw/hello-json-custom.sh > 2. Error message is not clear enough. I typed "jdk.desktip" by mistake in > requires section in modulebrowser, and then I got an error said > "modulebrowser cannot be solved" when installing the module into module > library. It should tell "jdk.desktip cannot be solved" instead. Thanks - I'll look into that. Best regards, David From david.bosschaert at gmail.com Wed Jul 4 06:57:44 2012 From: david.bosschaert at gmail.com (david.bosschaert at gmail.com) Date: Wed, 04 Jul 2012 13:57:44 +0000 Subject: hg: penrose/penrose: Start of documentation for module-info.json files. Message-ID: <20120704135744.7682C47CCC@hg.openjdk.java.net> Changeset: 9b7beb1f525b Author: davidb Date: 2012-07-04 14:56 +0100 URL: http://hg.openjdk.java.net/penrose/penrose/rev/9b7beb1f525b Start of documentation for module-info.json files. + doc/PenroseModuleInfoJSON.html + doc/PenroseModuleInfoJSON.odt From david.bosschaert at gmail.com Wed Jul 4 07:04:33 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Wed, 4 Jul 2012 15:04:33 +0100 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> Message-ID: On 4 July 2012 12:04, David Bosschaert wrote: > On 4 July 2012 07:36, Shi Jun Zhang wrote: >> 1. We need to add some document on how to write JSON format module info. I >> have to look into source code to learn how module-info.json structures and >> how to add modifiers. > > Yes, this is correct. It would be great if we had a wiki to host this > information. But in the absence of that I'll create a document and > will share it some other way. > Currently there are 2 system tests that can be used as example: > * http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/507fae0a1d80/test/org/openjdk/jigsaw/hello-json.sh > * http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/1d2576346081/test/org/openjdk/jigsaw/hello-json-custom.sh I have checked some documentation in to the penrose code base in the absence of a wiki. You can find it here: http://hg.openjdk.java.net/penrose/penrose/raw-file/9b7beb1f525b/doc/PenroseModuleInfoJSON.html Hope this helps, let me know if you're missing anything. Cheers, David From david.bosschaert at gmail.com Wed Jul 4 07:42:29 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Wed, 4 Jul 2012 15:42:29 +0100 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> Message-ID: Hi Shi Jun, On 4 July 2012 12:04, David Bosschaert wrote: > On 4 July 2012 07:36, Shi Jun Zhang wrote: >> 2. Error message is not clear enough. I typed "jdk.desktip" by mistake in >> requires section in modulebrowser, and then I got an error said >> "modulebrowser cannot be solved" when installing the module into module >> library. It should tell "jdk.desktip cannot be solved" instead. > > Thanks - I'll look into that. Actually this is more of an issue for the Jigsaw resolver. It should report better why a module cannot be resolved, so let's say com.greetings.json has a dependency that isn't found, it simply reports this: org.openjdk.jigsaw.ConfigurationException: com.greetings.json@=0.1: Cannot resolve at org.openjdk.jigsaw.Resolver.fail(Resolver.java:91) at org.openjdk.jigsaw.Resolver.run(Resolver.java:460) at org.openjdk.jigsaw.Configurator.configure(Configurator.java:144) at org.openjdk.jigsaw.Configurator.configure(Configurator.java:204) at org.openjdk.jigsaw.SimpleLibrary.configureWhileModuleDirectoryLocked(SimpleLibrary.java:1720) at org.openjdk.jigsaw.SimpleLibrary.installFromManifests(SimpleLibrary.java:1154) at org.openjdk.jigsaw.cli.Librarian$Install.go(Librarian.java:207) If the resolver would give a better error message that would resolve your issue. The resolver is independent from the JSON module metadata, because the module metadata is internally represented in the same way, regardless of whether it was read from a module-info.json or a module-info.class file. With the module-info.java you get this warning earlier, during the javac process as it converts the .java file into a .class file. The .json file does not need to be compiled, but it would be good if the javac compiler could validate it in the future. BTW the error message from javac doesn't tell you why the resolution failed either right now... Best regards, David From paul.sandoz at oracle.com Wed Jul 4 10:45:23 2012 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Wed, 4 Jul 2012 19:45:23 +0200 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com>

Message-ID: <6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> Hi, On Jul 4, 2012, at 4:42 PM, David Bosschaert wrote: > Hi Shi Jun, > > On 4 July 2012 12:04, David Bosschaert wrote: >> On 4 July 2012 07:36, Shi Jun Zhang wrote: >>> 2. Error message is not clear enough. I typed "jdk.desktip" by mistake in >>> requires section in modulebrowser, and then I got an error said >>> "modulebrowser cannot be solved" when installing the module into module >>> library. It should tell "jdk.desktip cannot be solved" instead. >> >> Thanks - I'll look into that. > > Actually this is more of an issue for the Jigsaw resolver. It should > report better why a module cannot be resolved, so let's say > com.greetings.json has a dependency that isn't found, it simply > reports this: > > org.openjdk.jigsaw.ConfigurationException: com.greetings.json@=0.1: > Cannot resolve > at org.openjdk.jigsaw.Resolver.fail(Resolver.java:91) > at org.openjdk.jigsaw.Resolver.run(Resolver.java:460) > at org.openjdk.jigsaw.Configurator.configure(Configurator.java:144) > at org.openjdk.jigsaw.Configurator.configure(Configurator.java:204) > at org.openjdk.jigsaw.SimpleLibrary.configureWhileModuleDirectoryLocked(SimpleLibrary.java:1720) > at org.openjdk.jigsaw.SimpleLibrary.installFromManifests(SimpleLibrary.java:1154) > at org.openjdk.jigsaw.cli.Librarian$Install.go(Librarian.java:207) > > If the resolver would give a better error message that would resolve > your issue. Yes, another TODO :-) Very important to make such errors as a clear and meaningful as possible. In the interim if you set the JIGSAW_TRACE environment variable e.g.: export JIGSAW_TRACE=1000 you will see tracing output from the resolver. > The resolver is independent from the JSON module metadata, > because the module metadata is internally represented in the same way, > regardless of whether it was read from a module-info.json or a > module-info.class file. > > With the module-info.java you get this warning earlier, during the > javac process as it converts the .java file into a .class file. The > .json file does not need to be compiled, but it would be good if the > javac compiler could validate it in the future. BTW the error message > from javac doesn't tell you why the resolution failed either right > now... > The resolver will also be used by javac, so i would expect an error when compiling such a module. Was the JSON module declaration modified after compilation? Paul. From zhangshj at linux.vnet.ibm.com Wed Jul 4 22:24:25 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Thu, 05 Jul 2012 05:24:25 +0000 Subject: hg: penrose/penrose: Remove the module-info.java files and use module-info.json only. Message-ID: <20120705052425.D2D4247CF1@hg.openjdk.java.net> Changeset: 7b97adf07bc7 Author: Shi Jun Zhang Date: 2012-07-05 13:23 +0800 URL: http://hg.openjdk.java.net/penrose/penrose/rev/7b97adf07bc7 Remove the module-info.java files and use module-info.json only. - demo/classloader/src/classloader/module-info.java - demo/classloader/src/foo/module-info.java ! demo/java2d/build.sh - demo/java2d/src/modules/java2d.demos.arcs/module-info.java - demo/java2d/src/modules/java2d.demos.clipping/module-info.java - demo/java2d/src/modules/java2d.demos/module-info.java - demo/modulebrowser/src/module-info.java From zhangshj at linux.vnet.ibm.com Wed Jul 4 22:30:04 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Thu, 05 Jul 2012 13:30:04 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> Message-ID: <4FF5265C.7090201@linux.vnet.ibm.com> On 7/4/2012 7:04 PM, David Bosschaert wrote: > On 4 July 2012 07:36, Shi Jun Zhang wrote: >> On 7/3/2012 3:44 PM, zhangshj at linux.vnet.ibm.com wrote: >>> Changeset: 39373c36d5e6 >>> Author: Shi Jun Zhang >>> Date: 2012-07-03 15:43 +0800 >>> URL: http://hg.openjdk.java.net/penrose/penrose/rev/39373c36d5e6 >>> >>> 1. Update Penrose demos to support JSON format module info. >>> 2. Update modulebrowser demo to avoid NPE. >>> >>> ! demo/classloader/README >>> ! demo/classloader/build.sh >>> + demo/classloader/src/classloader/META-INF/module-info.json >>> + demo/classloader/src/foo/META-INF/module-info.json >>> ! demo/java2d/README >>> + demo/java2d/src/resource/java2d.demos.arcs/META-INF/module-info.json >>> + demo/java2d/src/resource/java2d.demos.clipping/META-INF/module-info.json >>> + demo/java2d/src/resource/java2d.demos/META-INF/module-info.json >>> ! demo/modulebrowser/build.sh >>> + demo/modulebrowser/src/META-INF/module-info.json >>> ! demo/modulebrowser/src/demo/modulebrowser/LibraryNode.java >>> ! demo/modulebrowser/src/demo/modulebrowser/ModuleNode.java >>> ! demo/modulebrowser/src/demo/modulebrowser/RequiresNode.java >>> > Great stuff, Shi Jun! I think we should also remove the > module-info.java files. If there's anything that you're finding that > isn't working with purely module-info.json files please let me know > and I'll look into it. > Sure. I always thought the module cannot be compiled without module-info.java. It's not true. I have removed these module-info.java files and we can get them back later if needed. -- Regards, Shi Jun Zhang From zhangshj at linux.vnet.ibm.com Wed Jul 4 22:50:20 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Thu, 05 Jul 2012 13:50:20 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> Message-ID: <4FF52B1C.5020904@linux.vnet.ibm.com> On 7/4/2012 10:04 PM, David Bosschaert wrote: > On 4 July 2012 12:04, David Bosschaert wrote: >> On 4 July 2012 07:36, Shi Jun Zhang wrote: >>> 1. We need to add some document on how to write JSON format module info. I >>> have to look into source code to learn how module-info.json structures and >>> how to add modifiers. >> Yes, this is correct. It would be great if we had a wiki to host this >> information. But in the absence of that I'll create a document and >> will share it some other way. >> Currently there are 2 system tests that can be used as example: >> * http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/507fae0a1d80/test/org/openjdk/jigsaw/hello-json.sh >> * http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/1d2576346081/test/org/openjdk/jigsaw/hello-json-custom.sh > I have checked some documentation in to the penrose code base in the > absence of a wiki. You can find it here: > http://hg.openjdk.java.net/penrose/penrose/raw-file/9b7beb1f525b/doc/PenroseModuleInfoJSON.html > > Hope this helps, let me know if you're missing anything. > > Cheers, > > David > That's great. As exports and permits are just set of strings in ModuleInfo java object, can we simplify the representation in module-info.json? Such as: "exports" : [ "x.y.z" ], "permits" : [ "x", "y" ] -- Regards, Shi Jun Zhang From zhangshj at linux.vnet.ibm.com Wed Jul 4 22:55:15 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Thu, 05 Jul 2012 13:55:15 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com>

<6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> Message-ID: <4FF52C43.9030608@linux.vnet.ibm.com> On 7/5/2012 1:45 AM, Paul Sandoz wrote: > Hi, > > On Jul 4, 2012, at 4:42 PM, David Bosschaert wrote: > >> Hi Shi Jun, >> >> On 4 July 2012 12:04, David Bosschaert wrote: >>> On 4 July 2012 07:36, Shi Jun Zhang wrote: >>>> 2. Error message is not clear enough. I typed "jdk.desktip" by mistake in >>>> requires section in modulebrowser, and then I got an error said >>>> "modulebrowser cannot be solved" when installing the module into module >>>> library. It should tell "jdk.desktip cannot be solved" instead. >>> Thanks - I'll look into that. >> Actually this is more of an issue for the Jigsaw resolver. It should >> report better why a module cannot be resolved, so let's say >> com.greetings.json has a dependency that isn't found, it simply >> reports this: >> >> org.openjdk.jigsaw.ConfigurationException: com.greetings.json@=0.1: >> Cannot resolve >> at org.openjdk.jigsaw.Resolver.fail(Resolver.java:91) >> at org.openjdk.jigsaw.Resolver.run(Resolver.java:460) >> at org.openjdk.jigsaw.Configurator.configure(Configurator.java:144) >> at org.openjdk.jigsaw.Configurator.configure(Configurator.java:204) >> at org.openjdk.jigsaw.SimpleLibrary.configureWhileModuleDirectoryLocked(SimpleLibrary.java:1720) >> at org.openjdk.jigsaw.SimpleLibrary.installFromManifests(SimpleLibrary.java:1154) >> at org.openjdk.jigsaw.cli.Librarian$Install.go(Librarian.java:207) >> >> If the resolver would give a better error message that would resolve >> your issue. > Yes, another TODO :-) Very important to make such errors as a clear and meaningful as possible. > > In the interim if you set the JIGSAW_TRACE environment variable e.g.: > > export JIGSAW_TRACE=1000 > > you will see tracing output from the resolver. Thanks. That's helpful. > > >> The resolver is independent from the JSON module metadata, >> because the module metadata is internally represented in the same way, >> regardless of whether it was read from a module-info.json or a >> module-info.class file. >> >> With the module-info.java you get this warning earlier, during the >> javac process as it converts the .java file into a .class file. The >> .json file does not need to be compiled, but it would be good if the >> javac compiler could validate it in the future. BTW the error message >> from javac doesn't tell you why the resolution failed either right >> now... >> > The resolver will also be used by javac, so i would expect an error when compiling such a module. > > Was the JSON module declaration modified after compilation? > > Paul. > The module-info.json will not be compiled. We didn't do any changes in javac. -- Regards, Shi Jun Zhang From paul.sandoz at oracle.com Wed Jul 4 23:54:11 2012 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Thu, 5 Jul 2012 08:54:11 +0200 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <4FF52C43.9030608@linux.vnet.ibm.com> References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com>

<6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> <4FF52C43.9030608@linux.vnet.ibm.com> Message-ID: On Jul 5, 2012, at 7:55 AM, Shi Jun Zhang wrote: > >> >> >>> The resolver is independent from the JSON module metadata, >>> because the module metadata is internally represented in the same way, >>> regardless of whether it was read from a module-info.json or a >>> module-info.class file. >>> >>> With the module-info.java you get this warning earlier, during the >>> javac process as it converts the .java file into a .class file. The >>> .json file does not need to be compiled, but it would be good if the >>> javac compiler could validate it in the future. BTW the error message >>> from javac doesn't tell you why the resolution failed either right >>> now... >>> >> The resolver will also be used by javac, so i would expect an error when compiling such a module. >> >> Was the JSON module declaration modified after compilation? >> >> Paul. >> > The module-info.json will not be compiled. We didn't do any changes in javac. > Clarification: by compilation, i meant compilation of the module. When javac compiles a module it will use the resolver, the resolver in turn will use module decoration information. So if you did not get a ConfigurationException when compiling the module but did when you installed the module then either the module decoration was modified after the module compilation or something odd is gong on. Paul. From david.bosschaert at gmail.com Thu Jul 5 01:38:18 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Thu, 5 Jul 2012 09:38:18 +0100 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <4FF52B1C.5020904@linux.vnet.ibm.com> References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> <4FF52B1C.5020904@linux.vnet.ibm.com> Message-ID: On 5 July 2012 06:50, Shi Jun Zhang wrote: > On 7/4/2012 10:04 PM, David Bosschaert wrote: >> >> On 4 July 2012 12:04, David Bosschaert wrote: >>> >>> On 4 July 2012 07:36, Shi Jun Zhang wrote: >>>> >>>> 1. We need to add some document on how to write JSON format module info. >>>> I >>>> have to look into source code to learn how module-info.json structures >>>> and >>>> how to add modifiers. >>> >>> Yes, this is correct. It would be great if we had a wiki to host this >>> information. But in the absence of that I'll create a document and >>> will share it some other way. >>> Currently there are 2 system tests that can be used as example: >>> * >>> http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/507fae0a1d80/test/org/openjdk/jigsaw/hello-json.sh >>> * >>> http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/1d2576346081/test/org/openjdk/jigsaw/hello-json-custom.sh >> >> I have checked some documentation in to the penrose code base in the >> absence of a wiki. You can find it here: >> >> http://hg.openjdk.java.net/penrose/penrose/raw-file/9b7beb1f525b/doc/PenroseModuleInfoJSON.html >> >> Hope this helps, let me know if you're missing anything. >> >> Cheers, >> >> David >> > > That's great. As exports and permits are just set of strings in ModuleInfo > java object, can we simplify the representation in module-info.json? > Such as: "exports" : [ "x.y.z" ], "permits" : [ "x", "y" ] I actually made exports and permits JSON objects on purpose, because that way the value becomes extensible. In the case of exports, OSGi needs to be able to add version information (and possibly other attributes) to the export information. See the 'extensibility' section of [1] for an example. WRT to permits it's more a guess. I have a hunch that 'permits' may get more attributes in the future, that's why I turned it into an object. I think as a general rule its probably good to use JSON objects for anything that not purely a value. I.e. if the key is 'name' or 'version' then you're pretty sure you have a value but in other cases I using an object makes it possible to extend in the future without breaking bw compatibility. By that rule it would probably be better to rename the "class" entry into "main-class-name" as we're really talking about just a class name here. Cheers, David [1] http://hg.openjdk.java.net/penrose/penrose/raw-file/9b7beb1f525b/doc/PenroseModuleInfoJSON.html From zhangshj at linux.vnet.ibm.com Thu Jul 5 02:25:52 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Thu, 05 Jul 2012 17:25:52 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com>

<6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> <4FF52C43.9030608@linux.vnet.ibm.com> Message-ID: <4FF55DA0.8000907@linux.vnet.ibm.com> On 7/5/2012 2:54 PM, Paul Sandoz wrote: > On Jul 5, 2012, at 7:55 AM, Shi Jun Zhang wrote: >>> >>>> The resolver is independent from the JSON module metadata, >>>> because the module metadata is internally represented in the same way, >>>> regardless of whether it was read from a module-info.json or a >>>> module-info.class file. >>>> >>>> With the module-info.java you get this warning earlier, during the >>>> javac process as it converts the .java file into a .class file. The >>>> .json file does not need to be compiled, but it would be good if the >>>> javac compiler could validate it in the future. BTW the error message >>>> from javac doesn't tell you why the resolution failed either right >>>> now... >>>> >>> The resolver will also be used by javac, so i would expect an error when compiling such a module. >>> >>> Was the JSON module declaration modified after compilation? >>> >>> Paul. >>> >> The module-info.json will not be compiled. We didn't do any changes in javac. >> > Clarification: by compilation, i meant compilation of the module. > > When javac compiles a module it will use the resolver, the resolver in turn will use module decoration information. So if you did not get a ConfigurationException when compiling the module but did when you installed the module then either the module decoration was modified after the module compilation or something odd is gong on. > > Paul. javac will search module info in module path and source path and use the resolver to resolve it, but javac doesn't recognize module-info.json. With setting JIGSAW_TRACE=1000, I can see that javac will only try to resolve jdk module if there is no module-info.java in source. This causes no error message at compile time with JSON format module info. -- Regards, Shi Jun Zhang From zhangshj at linux.vnet.ibm.com Thu Jul 5 02:30:49 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Thu, 05 Jul 2012 17:30:49 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com> <4FF52B1C.5020904@linux.vnet.ibm.com> Message-ID: <4FF55EC9.40406@linux.vnet.ibm.com> On 7/5/2012 4:38 PM, David Bosschaert wrote: > On 5 July 2012 06:50, Shi Jun Zhang wrote: >> On 7/4/2012 10:04 PM, David Bosschaert wrote: >>> On 4 July 2012 12:04, David Bosschaert wrote: >>>> On 4 July 2012 07:36, Shi Jun Zhang wrote: >>>>> 1. We need to add some document on how to write JSON format module info. >>>>> I >>>>> have to look into source code to learn how module-info.json structures >>>>> and >>>>> how to add modifiers. >>>> Yes, this is correct. It would be great if we had a wiki to host this >>>> information. But in the absence of that I'll create a document and >>>> will share it some other way. >>>> Currently there are 2 system tests that can be used as example: >>>> * >>>> http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/507fae0a1d80/test/org/openjdk/jigsaw/hello-json.sh >>>> * >>>> http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/1d2576346081/test/org/openjdk/jigsaw/hello-json-custom.sh >>> I have checked some documentation in to the penrose code base in the >>> absence of a wiki. You can find it here: >>> >>> http://hg.openjdk.java.net/penrose/penrose/raw-file/9b7beb1f525b/doc/PenroseModuleInfoJSON.html >>> >>> Hope this helps, let me know if you're missing anything. >>> >>> Cheers, >>> >>> David >>> >> That's great. As exports and permits are just set of strings in ModuleInfo >> java object, can we simplify the representation in module-info.json? >> Such as: "exports" : [ "x.y.z" ], "permits" : [ "x", "y" ] > I actually made exports and permits JSON objects on purpose, because > that way the value becomes extensible. > > In the case of exports, OSGi needs to be able to add version > information (and possibly other attributes) to the export information. > See the 'extensibility' section of [1] for an example. > > WRT to permits it's more a guess. I have a hunch that 'permits' may > get more attributes in the future, that's why I turned it into an > object. > > I think as a general rule its probably good to use JSON objects for > anything that not purely a value. I.e. if the key is 'name' or > 'version' then you're pretty sure you have a value but in other cases > I using an object makes it possible to extend in the future without > breaking bw compatibility. By that rule it would probably be better to > rename the "class" entry into "main-class-name" as we're really > talking about just a class name here. > > Cheers, > > David > > [1] http://hg.openjdk.java.net/penrose/penrose/raw-file/9b7beb1f525b/doc/PenroseModuleInfoJSON.html > Get it. Just think the JSON format is a little tedious. -- Regards, Shi Jun Zhang From paul.sandoz at oracle.com Thu Jul 5 02:45:22 2012 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Thu, 5 Jul 2012 11:45:22 +0200 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <4FF55DA0.8000907@linux.vnet.ibm.com> References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com>

<6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> <4FF52C43.9030608@linux.vnet.ibm.com> <4FF55DA0.8000907@linux.vnet.ibm.com> Message-ID: <4E106217-64BE-49B7-975F-9D26FE374AA3@oracle.com> On Jul 5, 2012, at 11:25 AM, Shi Jun Zhang wrote: >>>> >>> The module-info.json will not be compiled. We didn't do any changes in javac. >>> >> Clarification: by compilation, i meant compilation of the module. >> >> When javac compiles a module it will use the resolver, the resolver in turn will use module decoration information. So if you did not get a ConfigurationException when compiling the module but did when you installed the module then either the module decoration was modified after the module compilation or something odd is gong on. >> >> Paul. > > javac will search module info in module path and source path and use the resolver to resolve it, but javac doesn't recognize module-info.json. With setting JIGSAW_TRACE=1000, I can see that javac will only try to resolve jdk module if there is no module-info.java in source. This causes no error message at compile time with JSON format module info. > Ah! that explains it, and i now understand your comment "We didn't do any changes in javac" :-) So you are essentially compiling the module in "classpath" mode because javac does not recognize the source as being module source. Paul. From zhangshj at linux.vnet.ibm.com Thu Jul 5 19:22:16 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Fri, 06 Jul 2012 10:22:16 +0800 Subject: hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info. In-Reply-To: <4E106217-64BE-49B7-975F-9D26FE374AA3@oracle.com> References: <20120703074432.4203547C5E@hg.openjdk.java.net> <4FF3E47A.9080206@linux.vnet.ibm.com>

<6649649E-E0AB-4084-82D1-34BBE5B89922@oracle.com> <4FF52C43.9030608@linux.vnet.ibm.com> <4FF55DA0.8000907@linux.vnet.ibm.com> <4E106217-64BE-49B7-975F-9D26FE374AA3@oracle.com> <4FF64BD8.4090608@linux.vnet.ibm.com> Message-ID: On Jul 6, 2012, at 4:22 AM, Shi Jun Zhang wrote: > On 7/5/2012 5:45 PM, Paul Sandoz wrote: >> On Jul 5, 2012, at 11:25 AM, Shi Jun Zhang wrote: >>>>> The module-info.json will not be compiled. We didn't do any changes in javac. >>>>> >>>> Clarification: by compilation, i meant compilation of the module. >>>> >>>> When javac compiles a module it will use the resolver, the resolver in turn will use module decoration information. So if you did not get a ConfigurationException when compiling the module but did when you installed the module then either the module decoration was modified after the module compilation or something odd is gong on. >>>> >>>> Paul. >>> javac will search module info in module path and source path and use the resolver to resolve it, but javac doesn't recognize module-info.json. With setting JIGSAW_TRACE=1000, I can see that javac will only try to resolve jdk module if there is no module-info.java in source. This causes no error message at compile time with JSON format module info. >>> >> Ah! that explains it, and i now understand your comment "We didn't do any changes in javac" :-) >> >> So you are essentially compiling the module in "classpath" mode because javac does not recognize the source as being module source. >> >> Paul. > > So the next step maybe is to do some check for JSON format module info at compile time. > Yes, instead of checking for module-info.java and creating a ModuleInfo from that you would need to check for the JSON equivalent and create a ModuleInfo from that, thus informing javac to switch to modular compilation mode. Paul. From zhangshj at linux.vnet.ibm.com Mon Jul 9 23:36:00 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Tue, 10 Jul 2012 06:36:00 +0000 Subject: hg: penrose/penrose: Add a tool to convert java class format module info to JSON format. Message-ID: <20120710063600.70E0347ECC@hg.openjdk.java.net> Changeset: 154159ca2f37 Author: Shi Jun Zhang Date: 2012-07-10 14:34 +0800 URL: http://hg.openjdk.java.net/penrose/penrose/rev/154159ca2f37 Add a tool to convert java class format module info to JSON format. + tools/ModuleInfoConverter/README + tools/ModuleInfoConverter/src/org/openjdk/penrose/tools/JSONWriter.java + tools/ModuleInfoConverter/src/org/openjdk/penrose/tools/ModuleInfoConverter.java From zhangshj at linux.vnet.ibm.com Tue Jul 10 00:47:28 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Tue, 10 Jul 2012 15:47:28 +0800 Subject: RFR: JSONParser cannot resolve info-json created on Windows Message-ID: <4FFBDE10.1090109@linux.vnet.ibm.com> http://cr.openjdk.java.net/~zhangshj/penrose/JSONParser/webrev.00/ Small fix. Replace '\r' with ' ' when JSONParser parses the JSON format module info file created on Windows. -- Regards, Shi Jun Zhang From david.bosschaert at gmail.com Tue Jul 10 02:24:12 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Tue, 10 Jul 2012 10:24:12 +0100 Subject: RFR: JSONParser cannot resolve info-json created on Windows In-Reply-To: <4FFBDE10.1090109@linux.vnet.ibm.com> References: <4FFBDE10.1090109@linux.vnet.ibm.com> Message-ID: Well-spotted, Shi Jun. Many thanks! David On 10 July 2012 08:47, Shi Jun Zhang wrote: > http://cr.openjdk.java.net/~zhangshj/penrose/JSONParser/webrev.00/ > > Small fix. Replace '\r' with ' ' when JSONParser parses the JSON format > module info file created on Windows. > > -- > Regards, > > Shi Jun Zhang > > From zhangshj at linux.vnet.ibm.com Tue Jul 10 19:25:20 2012 From: zhangshj at linux.vnet.ibm.com (zhangshj at linux.vnet.ibm.com) Date: Wed, 11 Jul 2012 02:25:20 +0000 Subject: hg: penrose/jigsaw/jdk: Replace \r with blank space in JSONParser for Windows. Message-ID: <20120711022601.1C26347F42@hg.openjdk.java.net> Changeset: c069f6d4f301 Author: Shi Jun Zhang Date: 2012-07-10 15:39 +0800 URL: http://hg.openjdk.java.net/penrose/jigsaw/jdk/rev/c069f6d4f301 Replace \r with blank space in JSONParser for Windows. ! src/share/classes/java/lang/module/JSONParser.java From dalibor.topic at oracle.com Thu Jul 12 03:10:02 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 12 Jul 2012 12:10:02 +0200 Subject: The state of the penrose web pages/wiki In-Reply-To: <4FF3E5F7.3030105@linux.vnet.ibm.com> References: <4FB3CA87.1070105@oracle.com> <4FB64636.1020401@oracle.com> <4FB64DC4.4070807@oracle.com> <4FF3E5F7.3030105@linux.vnet.ibm.com> Message-ID: <4FFEA27A.8010007@oracle.com> On 7/4/12 8:43 AM, Shi Jun Zhang wrote: > On 5/18/2012 9:25 PM, Dalibor Topic wrote: >> On 5/18/12 3:06 PM, David Bosschaert wrote: >>> Thanks Dalibor - Yes, that would help :) >>> >> OK - page updated. >> >> cheers, >> dalibor topic > > Hi Dalibor, > > Could you help to add penrose-discuss mailing list on the Penrose project page? It's under the 3-clause BSD license and also GPLv2. > Sure - do you have some draft text I can use? cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Thu Jul 12 04:47:07 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 12 Jul 2012 13:47:07 +0200 Subject: The state of the penrose web pages/wiki In-Reply-To: <4FFEA27A.8010007@oracle.com> References: <4FB3CA87.1070105@oracle.com> <4FB64636.1020401@oracle.com> <4FB64DC4.4070807@oracle.com> <4FF3E5F7.3030105@linux.vnet.ibm.com> <4FFEA27A.8010007@oracle.com> Message-ID: <4FFEB93B.4020008@oracle.com> On 7/12/12 12:10 PM, Dalibor Topic wrote: > On 7/4/12 8:43 AM, Shi Jun Zhang wrote: >> On 5/18/2012 9:25 PM, Dalibor Topic wrote: >>> On 5/18/12 3:06 PM, David Bosschaert wrote: >>>> Thanks Dalibor - Yes, that would help :) >>>> >>> OK - page updated. >>> >>> cheers, >>> dalibor topic >> >> Hi Dalibor, >> >> Could you help to add penrose-discuss mailing list on the Penrose project page? It's under the 3-clause BSD license and also GPLv2. >> > Sure - do you have some draft text I can use? Nevermind, here's a proposed update: robilad$ hg diff diff -r 0c0c424742f5 src/projects/penrose/index.html --- a/src/projects/penrose/index.html Wed Jul 11 08:53:41 2012 +0200 +++ b/src/projects/penrose/index.html Thu Jul 12 13:40:20 2012 +0200 @@ -21,8 +21,12 @@

Mailing list

- penrose-dev - (GPLv2 license) + penrose-dev - + Technical discussion related to the Penrose Project (GPLv2 license) +
+ penrose-discuss - + General discussion related to the Penrose Project (3-clause BSD license and also GPLv2 license)

OK to push? cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From zhangshj at linux.vnet.ibm.com Thu Jul 12 20:21:13 2012 From: zhangshj at linux.vnet.ibm.com (Shi Jun Zhang) Date: Fri, 13 Jul 2012 11:21:13 +0800 Subject: The state of the penrose web pages/wiki In-Reply-To: <4FFEB93B.4020008@oracle.com> References: <4FB3CA87.1070105@oracle.com> <4FB64636.1020401@oracle.com> <4FB64DC4.4070807@oracle.com> <4FF3E5F7.3030105@linux.vnet.ibm.com> <4FFEA27A.8010007@oracle.com> <4FFEB93B.4020008@oracle.com> Message-ID: <4FFF9429.4030300@linux.vnet.ibm.com> On 7/12/2012 7:47 PM, Dalibor Topic wrote: > On 7/12/12 12:10 PM, Dalibor Topic wrote: >> On 7/4/12 8:43 AM, Shi Jun Zhang wrote: >>> On 5/18/2012 9:25 PM, Dalibor Topic wrote: >>>> On 5/18/12 3:06 PM, David Bosschaert wrote: >>>>> Thanks Dalibor - Yes, that would help :) >>>>> >>>> OK - page updated. >>>> >>>> cheers, >>>> dalibor topic >>> Hi Dalibor, >>> >>> Could you help to add penrose-discuss mailing list on the Penrose project page? It's under the 3-clause BSD license and also GPLv2. >>> >> Sure - do you have some draft text I can use? > Nevermind, here's a proposed update: > > robilad$ hg diff > diff -r 0c0c424742f5 src/projects/penrose/index.html > --- a/src/projects/penrose/index.html Wed Jul 11 08:53:41 2012 +0200 > +++ b/src/projects/penrose/index.html Thu Jul 12 13:40:20 2012 +0200 > @@ -21,8 +21,12 @@ >

Mailing list >

> -penrose-dev > - (GPLv2 license) > +penrose-dev - > + Technical discussion related to the Penrose Project (GPLv2 license) > +
> +penrose-discuss - > + General discussion related to the Penrose Project (3-clause BSD license and also GPLv2 license) >

> > OK to push? > > cheers, > dalibor topic > > Yes. Thank you for the kind help. -- Regards, Shi Jun Zhang From dalibor.topic at oracle.com Fri Jul 13 08:10:31 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 13 Jul 2012 17:10:31 +0200 Subject: The state of the penrose web pages/wiki In-Reply-To: <4FFF9429.4030300@linux.vnet.ibm.com> References: <4FB3CA87.1070105@oracle.com> <4FB64636.1020401@oracle.com> <4FB64DC4.4070807@oracle.com> <4FF3E5F7.3030105@linux.vnet.ibm.com> <4FFEA27A.8010007@oracle.com> <4FFEB93B.4020008@oracle.com> <4FFF9429.4030300@linux.vnet.ibm.com> Message-ID: <50003A67.9070404@oracle.com> On 7/13/12 5:21 AM, Shi Jun Zhang wrote: > Yes. Thank you for the kind help. Thanks for the review. Pushed! cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment