hg: penrose/penrose: 1. Update Penrose demos to support JSON format module info.

[David Bosschaert]

On 4 July 2012 07:36, Shi Jun Zhang <zhangshj at linux.vnet.ibm.com> wrote:
> On 7/3/2012 3:44 PM, zhangshj at linux.vnet.ibm.com wrote:
>>
>> Changeset: 39373c36d5e6
>> Author:    Shi Jun Zhang<zhangshj at linux.vnet.ibm.com>
>> Date:      2012-07-03 15:43 +0800
>> URL:       http://hg.openjdk.java.net/penrose/penrose/rev/39373c36d5e6
>>
>> 1. Update Penrose demos to support JSON format module info.
>> 2. Update modulebrowser demo to avoid NPE.
>>
>> ! demo/classloader/README
>> ! demo/classloader/build.sh
>> + demo/classloader/src/classloader/META-INF/module-info.json
>> + demo/classloader/src/foo/META-INF/module-info.json
>> ! demo/java2d/README
>> + demo/java2d/src/resource/java2d.demos.arcs/META-INF/module-info.json
>> + demo/java2d/src/resource/java2d.demos.clipping/META-INF/module-info.json
>> + demo/java2d/src/resource/java2d.demos/META-INF/module-info.json
>> ! demo/modulebrowser/build.sh
>> + demo/modulebrowser/src/META-INF/module-info.json
>> ! demo/modulebrowser/src/demo/modulebrowser/LibraryNode.java
>> ! demo/modulebrowser/src/demo/modulebrowser/ModuleNode.java
>> ! demo/modulebrowser/src/demo/modulebrowser/RequiresNode.java
>>

Great stuff, Shi Jun! I think we should also remove the
module-info.java files. If there's anything that you're finding that
isn't working with purely module-info.json files please let me know
and I'll look into it.

> Some issues I find when updating the demos to support JSON format module
> info.
>
> 1. We need to add some document on how to write JSON format module info. I
> have to look into source code to learn how module-info.json structures and
> how to add modifiers.

Yes, this is correct. It would be great if we had a wiki to host this
information. But in the absence of that I'll create a document and
will share it some other way.
Currently there are 2 system tests that can be used as example:
* http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/507fae0a1d80/test/org/openjdk/jigsaw/hello-json.sh
* http://hg.openjdk.java.net/penrose/jigsaw/jdk/file/1d2576346081/test/org/openjdk/jigsaw/hello-json-custom.sh

> 2. Error message is not clear enough. I typed "jdk.desktip" by mistake in
> requires section in modulebrowser, and then I got an error said
> "modulebrowser cannot be solved" when installing the module into module
> library. It should tell "jdk.desktip cannot be solved" instead.

Thanks - I'll look into that.

Best regards,

David