From david.holmes at oracle.com Mon Aug 3 05:51:58 2015 From: david.holmes at oracle.com (David Holmes) Date: Mon, 3 Aug 2015 15:51:58 +1000 Subject: RFR (S) 8080298: Clean up os::...::supports_variable_stack_size() Message-ID: <55BF017E.3070801@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8080298 webrev: http://cr.openjdk.java.net/~dholmes/8080298/webrev/ To support the old LinuxThreads implementation we had to distinguish between threading libraries with fixed-stack-size threads (LinuxThreads), and variable-stack-sized-threads (NPTL). As LinuxThreads support was removed years ago and all the code related to it has now been removed, we have a situation where supports_variable_stack_size() is always true and so the function and its use can be removed. While this notion was only ever relevant to Linux it also got copied across to the BSD and AIX ports. Thanks, David From david.holmes at oracle.com Mon Aug 3 06:40:12 2015 From: david.holmes at oracle.com (David Holmes) Date: Mon, 3 Aug 2015 16:40:12 +1000 Subject: RFR (S) 8080298: Clean up os::...::supports_variable_stack_size() In-Reply-To: References: <55BF017E.3070801@oracle.com> Message-ID: <55BF0CCC.6090905@oracle.com> Thanks Kim! David On 3/08/2015 4:15 PM, Kim Barrett wrote: > On Aug 3, 2015, at 1:51 AM, David Holmes wrote: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8080298 >> >> webrev: http://cr.openjdk.java.net/~dholmes/8080298/webrev/ >> >> To support the old LinuxThreads implementation we had to distinguish between threading libraries with fixed-stack-size threads (LinuxThreads), and variable-stack-sized-threads (NPTL). As LinuxThreads support was removed years ago and all the code related to it has now been removed, we have a situation where supports_variable_stack_size() is always true and so the function and its use can be removed. >> >> While this notion was only ever relevant to Linux it also got copied across to the BSD and AIX ports. > > Looks good. > From volker.simonis at gmail.com Mon Aug 3 08:58:22 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 3 Aug 2015 10:58:22 +0200 Subject: RFR (S) 8080298: Clean up os::...::supports_variable_stack_size() In-Reply-To: <55BF017E.3070801@oracle.com> References: <55BF017E.3070801@oracle.com> Message-ID: Hi David, the change looks good. Thanks for fixing our platforms as well. Regards, Volker On Mon, Aug 3, 2015 at 7:51 AM, David Holmes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8080298 > > webrev: http://cr.openjdk.java.net/~dholmes/8080298/webrev/ > > To support the old LinuxThreads implementation we had to distinguish > between threading libraries with fixed-stack-size threads (LinuxThreads), > and variable-stack-sized-threads (NPTL). As LinuxThreads support was > removed years ago and all the code related to it has now been removed, we > have a situation where supports_variable_stack_size() is always true and so > the function and its use can be removed. > > While this notion was only ever relevant to Linux it also got copied > across to the BSD and AIX ports. > > Thanks, > David > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Mon Aug 3 09:09:18 2015 From: david.holmes at oracle.com (David Holmes) Date: Mon, 3 Aug 2015 19:09:18 +1000 Subject: RFR (S) 8080298: Clean up os::...::supports_variable_stack_size() In-Reply-To: References: <55BF017E.3070801@oracle.com> Message-ID: <55BF2FBE.7020607@oracle.com> Thanks Volker! David On 3/08/2015 6:58 PM, Volker Simonis wrote: > Hi David, > > the change looks good. > Thanks for fixing our platforms as well. > > Regards, > Volker > > > On Mon, Aug 3, 2015 at 7:51 AM, David Holmes > wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080298 > > webrev: http://cr.openjdk.java.net/~dholmes/8080298/webrev/ > > To support the old LinuxThreads implementation we had to distinguish > between threading libraries with fixed-stack-size threads > (LinuxThreads), and variable-stack-sized-threads (NPTL). As > LinuxThreads support was removed years ago and all the code related > to it has now been removed, we have a situation where > supports_variable_stack_size() is always true and so the function > and its use can be removed. > > While this notion was only ever relevant to Linux it also got copied > across to the BSD and AIX ports. > > Thanks, > David > > From thomas.stuefe at gmail.com Mon Aug 3 13:20:57 2015 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Mon, 3 Aug 2015 15:20:57 +0200 Subject: RFR (S) 8080298: Clean up os::...::supports_variable_stack_size() In-Reply-To: <55BF017E.3070801@oracle.com> References: <55BF017E.3070801@oracle.com> Message-ID: Hi David, looks good, thank you for doing this. Kind Regards, Thomas On Mon, Aug 3, 2015 at 7:51 AM, David Holmes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8080298 > > webrev: http://cr.openjdk.java.net/~dholmes/8080298/webrev/ > > To support the old LinuxThreads implementation we had to distinguish > between threading libraries with fixed-stack-size threads (LinuxThreads), > and variable-stack-sized-threads (NPTL). As LinuxThreads support was > removed years ago and all the code related to it has now been removed, we > have a situation where supports_variable_stack_size() is always true and so > the function and its use can be removed. > > While this notion was only ever relevant to Linux it also got copied > across to the BSD and AIX ports. > > Thanks, > David > -------------- next part -------------- An HTML attachment was scrubbed... URL: From kim.barrett at oracle.com Mon Aug 3 06:15:55 2015 From: kim.barrett at oracle.com (Kim Barrett) Date: Mon, 03 Aug 2015 06:15:55 -0000 Subject: RFR (S) 8080298: Clean up os::...::supports_variable_stack_size() In-Reply-To: <55BF017E.3070801@oracle.com> References: <55BF017E.3070801@oracle.com> Message-ID: On Aug 3, 2015, at 1:51 AM, David Holmes wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080298 > > webrev: http://cr.openjdk.java.net/~dholmes/8080298/webrev/ > > To support the old LinuxThreads implementation we had to distinguish between threading libraries with fixed-stack-size threads (LinuxThreads), and variable-stack-sized-threads (NPTL). As LinuxThreads support was removed years ago and all the code related to it has now been removed, we have a situation where supports_variable_stack_size() is always true and so the function and its use can be removed. > > While this notion was only ever relevant to Linux it also got copied across to the BSD and AIX ports. Looks good.