From david.holmes at oracle.com Tue May 15 01:23:43 2018 From: david.holmes at oracle.com (David Holmes) Date: Tue, 15 May 2018 11:23:43 +1000 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) Message-ID: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> The JEP-181 RFR has just gone out with the intent to have this JEP targeted and integrated by the end of the month, for JDK 11. http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-May/032228.html One part of this work requires platform specific changes to the templateTable to address the use of invokeinterface for private interface method calls. I have implemented and tested this code on x86 and sparc. For the other platforms I have provided the code based on what I did for x86 and sparc, and on similar code for the given architecture. It would be very much appreciated if I could get assistance from the other platform maintainers to build and test this code on each platform, and provide me with any fixes needed. I'll also note that the Zero interpreter will need to be updated to support the JVMS changes that come with this. I've filed: https://bugs.openjdk.java.net/browse/JDK-8203188 for the Zero folk to use. Thanks, David From adinn at redhat.com Tue May 15 16:11:24 2018 From: adinn at redhat.com (Andrew Dinn) Date: Tue, 15 May 2018 17:11:24 +0100 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) In-Reply-To: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> References: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> Message-ID: <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> On 15/05/18 02:23, David Holmes wrote: > The JEP-181 RFR has just gone out with the intent to have this JEP > targeted and integrated by the end of the month, for JDK 11. > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-May/032228.html > > One part of this work requires platform specific changes to the > templateTable to address the use of invokeinterface for private > interface method calls. I have implemented and tested this code on x86 > and sparc. For the other platforms I have provided the code based on > what I did for x86 and sparc, and on similar code for the given > architecture. It would be very much appreciated if I could get > assistance from the other platform maintainers to build and test this > code on each platform, and provide me with any fixes needed. I have successfully built the AArch64 port with this patch and run some simple programs without problem. I am currently running tier1 tests and will follow-up with a status when they complete. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From david.holmes at oracle.com Tue May 15 21:51:03 2018 From: david.holmes at oracle.com (David Holmes) Date: Wed, 16 May 2018 07:51:03 +1000 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) In-Reply-To: <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> References: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> Message-ID: <5fc715ca-53a1-723d-8dba-5c847c43d2f3@oracle.com> On 16/05/2018 2:11 AM, Andrew Dinn wrote: > On 15/05/18 02:23, David Holmes wrote: >> The JEP-181 RFR has just gone out with the intent to have this JEP >> targeted and integrated by the end of the month, for JDK 11. >> >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-May/032228.html >> >> One part of this work requires platform specific changes to the >> templateTable to address the use of invokeinterface for private >> interface method calls. I have implemented and tested this code on x86 >> and sparc. For the other platforms I have provided the code based on >> what I did for x86 and sparc, and on similar code for the given >> architecture. It would be very much appreciated if I could get >> assistance from the other platform maintainers to build and test this >> code on each platform, and provide me with any fixes needed. > > I have successfully built the AArch64 port with this patch and run some > simple programs without problem. I am currently running tier1 tests and > will follow-up with a status when they complete. Thanks Andrew that's great to hear. I should have mentioned that the key tests to run are: hotspot/jtreg/runtime/Nestmates jdk/java/lang/invoke/PrivateInterfaceCall.java but tier1 one should encompass those. Thanks again, David > > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander > From adinn at redhat.com Wed May 16 11:23:10 2018 From: adinn at redhat.com (Andrew Dinn) Date: Wed, 16 May 2018 12:23:10 +0100 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) In-Reply-To: <5fc715ca-53a1-723d-8dba-5c847c43d2f3@oracle.com> References: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> <5fc715ca-53a1-723d-8dba-5c847c43d2f3@oracle.com> Message-ID: On 15/05/18 22:51, David Holmes wrote: > I should have mentioned that the key tests to run are: > > hotspot/jtreg/runtime/Nestmates > jdk/java/lang/invoke/PrivateInterfaceCall.java > > but tier1 one should encompass those. Well, I am sure you will be pleased to know that those tests all passed. Unfortunately, a few of the other tier1 tests failed (or, in some cases, failed to run because of setup/compile errors). I am not convinced the are anything to do with your change set. I am rerunning tier1 minus your changes to see if the same failures occur before the patch. I will let you know if anything points a finger at the change set once I am able to compare before with after. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From david.holmes at oracle.com Wed May 16 11:50:36 2018 From: david.holmes at oracle.com (David Holmes) Date: Wed, 16 May 2018 21:50:36 +1000 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) In-Reply-To: References: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> <5fc715ca-53a1-723d-8dba-5c847c43d2f3@oracle.com> Message-ID: <3f860977-8db3-32ac-ed2a-6fb724744947@oracle.com> On 16/05/2018 9:23 PM, Andrew Dinn wrote: > On 15/05/18 22:51, David Holmes wrote: >> I should have mentioned that the key tests to run are: >> >> hotspot/jtreg/runtime/Nestmates >> jdk/java/lang/invoke/PrivateInterfaceCall.java >> >> but tier1 one should encompass those. > Well, I am sure you will be pleased to know that those tests all passed. Very pleased! A little surprised that purely by inspection I was able to get the Aarch64 assembly correct. :) > Unfortunately, a few of the other tier1 tests failed (or, in some cases, > failed to run because of setup/compile errors). I am not convinced the > are anything to do with your change set. I am rerunning tier1 minus your > changes to see if the same failures occur before the patch. > > I will let you know if anything points a finger at the change set once I > am able to compare before with after. Thanks. I can't yet imagine anything that would cause other tier1 failures in a platform selective manner. David > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander > From adinn at redhat.com Wed May 16 14:06:38 2018 From: adinn at redhat.com (Andrew Dinn) Date: Wed, 16 May 2018 15:06:38 +0100 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) In-Reply-To: <3f860977-8db3-32ac-ed2a-6fb724744947@oracle.com> References: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> <5fc715ca-53a1-723d-8dba-5c847c43d2f3@oracle.com> <3f860977-8db3-32ac-ed2a-6fb724744947@oracle.com> Message-ID: <9afb1f53-900d-fd5c-3f97-d864ed3a7ff6@redhat.com> On 16/05/18 12:50, David Holmes wrote: > On 16/05/2018 9:23 PM, Andrew Dinn wrote: . . . >> Well, I am sure you will be pleased to know that those tests all passed. > > Very pleased! A little surprised that purely by inspection I was able to > get the Aarch64 assembly correct. :) Yes, an impressive debut -- welcome to the aarch64-port team ;-) >> Unfortunately, a few of the other tier1 tests failed (or, in some cases, >> failed to run because of setup/compile errors). I am not convinced the >> are anything to do with your change set. I am rerunning tier1 minus your >> changes to see if the same failures occur before the patch. >> >> I will let you know if anything points a finger at the change set once I >> am able to compare before with after. > > Thanks. I can't yet imagine anything that would cause other tier1 > failures in a platform selective manner. The hotspot failures were the same before and after. They were mostly compiler/aot tests, which is no reason to suspect a problem in your patch. A couple of SA test failures appear to relate to a problem with jstack -- once again, I believe, no reason to be concerned as regards your patch. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From david.holmes at oracle.com Wed May 16 21:28:36 2018 From: david.holmes at oracle.com (David Holmes) Date: Thu, 17 May 2018 07:28:36 +1000 Subject: Assistance requested with JEP-181 Nest-based access control (nestmates) In-Reply-To: <9afb1f53-900d-fd5c-3f97-d864ed3a7ff6@redhat.com> References: <979cfafa-2001-fc21-2bb2-8cbfdadb0422@oracle.com> <6a50f6e0-cb9f-cc8d-e578-2baefcce0878@redhat.com> <5fc715ca-53a1-723d-8dba-5c847c43d2f3@oracle.com> <3f860977-8db3-32ac-ed2a-6fb724744947@oracle.com> <9afb1f53-900d-fd5c-3f97-d864ed3a7ff6@redhat.com> Message-ID: That's great news Andrew - many thanks. David On 17/05/2018 12:06 AM, Andrew Dinn wrote: > On 16/05/18 12:50, David Holmes wrote: >> On 16/05/2018 9:23 PM, Andrew Dinn wrote: > . . . >>> Well, I am sure you will be pleased to know that those tests all passed. >> >> Very pleased! A little surprised that purely by inspection I was able to >> get the Aarch64 assembly correct. :) > > Yes, an impressive debut -- welcome to the aarch64-port team ;-) > >>> Unfortunately, a few of the other tier1 tests failed (or, in some cases, >>> failed to run because of setup/compile errors). I am not convinced the >>> are anything to do with your change set. I am rerunning tier1 minus your >>> changes to see if the same failures occur before the patch. >>> >>> I will let you know if anything points a finger at the change set once I >>> am able to compare before with after. >> >> Thanks. I can't yet imagine anything that would cause other tier1 >> failures in a platform selective manner. > The hotspot failures were the same before and after. They were mostly > compiler/aot tests, which is no reason to suspect a problem in your > patch. A couple of SA test failures appear to relate to a problem with > jstack -- once again, I believe, no reason to be concerned as regards > your patch. > > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander > From aoqi at loongson.cn Wed May 30 05:54:22 2018 From: aoqi at loongson.cn (Ao Qi) Date: Wed, 30 May 2018 13:54:22 +0800 Subject: Current Status of OpenJDK 8 for mips64el Message-ID: Hi all, Here is current status of Loongson OpenJDK 8 for mips64el [1][2]: - currently supporting the Template Table Interpreter and C2. C1 is not supported yet and is under development. - passed JCK, jcstress and some other tests - updated to jdk8u172-b11, the latest released jdk8u - widely used in Loongson's products, especially server products As far as I know, all of the contributors (companies or individuals) has signed OCA. I know that jdk8u is a very old version. Is it possible to upstream the code to the community? Everybody who's interested is invited in building and testing the MIPS port. Comments and suggestions are welcome! Regards, Ao Qi [1] http://hg.loongnix.org/jdk8-mips64-public/ [2] http://mail.openjdk.java.net/pipermail/porters-dev/2016-May/000544.html