RFR: Use SIGRTMAX instead of __SIGRTMAX

Mikael Vidstedt mikael.vidstedt at oracle.com
Wed Apr 12 01:43:55 UTC 2017


> On Apr 11, 2017, at 6:34 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> On 12/04/2017 10:07 AM, Mikael Vidstedt wrote:
>> 
>> The JDK uses (in two places) __SIGRTMAX, but posix refers to SIGRTMAX without the double-underscores prefix. Also, posix also mentions that SIGRTMAX is not guaranteed to be a constant expression. musl doesn’t define __SIGRTMAX, and the definition of SIGRTMAX is not a constant expression.
>> 
>> This change updates the code to use SIGRTMAX,
> 
> Ok. Hotspot uses SIGRTMAX so there should be no issues here.
> 
>> and also moves the initialization of the static global variable sigWakeup in linux_close.c to be initialized in the function just before the signal handler gets set up.
> 
> Why do we need to move the initialization??

The musl definition of SIGRTMAX is not a constant expression - it’s a function call.

Cheers,
Mikael



More information about the portola-dev mailing list