RFR: Make Serviceability Agent attach functionality optional

[Mikael Vidstedt]

I took the liberty of pushing the suggested change.

Cheers,
Mikael

> On Jun 22, 2017, at 10:06 AM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
> 
> 
> Agreed. Does this look better?
> 
> http://cr.openjdk.java.net/~mikael/webrevs/portola/saattachdash/webrev.00/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/portola/saattachdash/webrev.00/webrev/>
> 
> Cheers,
> Mikael
> 
>> On Jun 16, 2017, at 8:11 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>> 
>> Hi Mikael,
>> 
>> Wading through my backlog here... :)
>> 
>> One small comment: I'd prefer if you rename the option "--enable-sa-attach". We try to use - as a separator between words in the configure arguments, instead of just mashing them together.
>> 
>> /Magnus
>> 
>> On 2017-04-13 18:19, Mikael Vidstedt wrote:
>>> The Serviceability Agent (aka. SA) has functionality to attach to running processes forcefully/without the cooperation of the VM, allowing “live” debugging even when the processes is stuck. On linux the implementation relies on the functionality provided by the thread_db.h header file.
>>> 
>>> musl doesn’t support thread_db.h (or any other thread debugging library for that sake). This patch makes the inclusion of the attach/live debugging support optional, and only includes it if the thread_db.h header file is available.
>>> 
>>> Note that the core debugging functionality still works without the attach/live debugging functionality in the SA (at least in theory, I haven’t taken core debugging for a spin yet).
>>> 
>>> top: http://cr.openjdk.java.net/~mikael/webrevs/portola/sathreaddb/webrev.00/webrev/
>>> hotspot: http://cr.openjdk.java.net/~mikael/webrevs/portola/sathreaddb/webrev.00/hotspot/webrev/
>>> 
>>> Cheers,
>>> Mikael
>>> 
>> 
>