RFR: Fix jtreg test java/lang/ProcessHandle/InfoTest.java

Siebenborn, Axel axel.siebenborn at sap.com
Tue Mar 20 14:00:35 UTC 2018


Hi Mikael,

thanks for your review.

I uploaded a  new webrev:
http://cr.openjdk.java.net/~asiebenborn/jtreg_ProcessHandler/webrev.01/

Regards,
Axel

> -----Original Message-----
> From: Mikael Vidstedt [mailto:mikael.vidstedt at oracle.com]
> Sent: Montag, 19. März 2018 18:07
> To: Siebenborn, Axel <axel.siebenborn at sap.com>
> Cc: portola-dev at openjdk.java.net
> Subject: Re: RFR: Fix jtreg test java/lang/ProcessHandle/InfoTest.java
> 
> 
> Looks like the are superfluous parenthesis around the new File() call on line
> 304, apart from that looks good. Send me a patch and I’ll help push it.
> 
> 
> (A reflection mostly unrelated to your change: the various platform checks
> (Windows, Unix, BusyBox, …) really should be using the common
> functionality from test/lib/jdk/test/lib/Platform.java.)
> 
> Cheers,
> Mikael
> 
> > On Mar 19, 2018, at 4:45 AM, Siebenborn, Axel
> <axel.siebenborn at sap.com> wrote:
> >
> > Hi,
> >
> > could I have a review for the following webrev:
> >
> > http://cr.openjdk.java.net/~asiebenborn/jtreg_ProcessHandler/webrev/
> >
> > /bin/sleep is a link to busybox and thats what ProcessHandle.Info
> command() returns.
> >
> > Regards,
> > Axel
> >



More information about the portola-dev mailing list