RFC: JEP 386 patch - minor cleanup
Alan Bateman
Alan.Bateman at oracle.com
Wed Aug 26 12:09:07 UTC 2020
On 08/07/2020 19:52, Mikael Vidstedt wrote:
>> java.base:
>>
>> - src/java.base/linux/native/libnet/linux_close.c - made (SIGRTMAX - 2)
>> a define
>> - src/java.base/unix/native/libjava/childproc.c - suggest to skip this
>> for now. Also, if the OS does not handle scripts without shebang it
>> should not be emulated.
> * jdk_util_md.h
>
> The same isnan comment as above.
>
> * INTERRUPT_SIGNAL
>
> Can the definition of INTERRUPT_SIGNAL (perhaps then with a better name) be moved to something like net_util_md.h so that it is shared for both files using it? I’d also remove the spaces around the arguments to pthread_kill in linux_close.c (pre-existing).
>
This came up in the review of JDK-8252248 on core-libs-dev too. The
xxx_close.c sources will be removed when the legacy (and not used by
default) PlainSocketImpl and PlainDatagramSocketImpl go away. Also
NativeThread.c is for signalling in the FileChannel implementation so
shouldn't have a dependency on net_util.
-Alan
More information about the portola-dev
mailing list