Fix for test/hotspot/jtreg/runtime/8176717/TestInheritFD.java on Alpine Linux

Mikael Vidstedt mikael.vidstedt at oracle.com
Sat Feb 15 07:05:15 UTC 2020


Thanks for doing that! I’ll sponsor this for you.

Cheers,
Mikael

> On Feb 13, 2020, at 2:40 AM, Alexander Scherbatiy <alexander.scherbatiy at bell-sw.com> wrote:
> 
> On 13.02.2020 01:18, Mikael Vidstedt wrote:
> 
>> I’m not completely sold on the concept of storing a boolean as a string in the command array. How about creating an actual class with an explicit field for that instead?
> 
> Here is the updated webrev where Command class is used instead of an array of strings:
> 
> http://cr.openjdk.java.net/~alexsch/portola/TestInheritFD/webrev.01/ <http://cr.openjdk.java.net/~alexsch/portola/TestInheritFD/webrev.01/>
> 
> Thanks,
> 
> Alexander.
> 
>> 
>> Cheers,
>> Mikael
>> 
>>> On Feb 10, 2020, at 5:22 AM, Alexander Scherbatiy <alexander.scherbatiy at bell-sw.com> wrote:
>>> 
>>> Hello,
>>> 
>>> The test test/hotspot/jtreg/runtime/8176717/TestInheritFD.java fails on Alpine Linux because "lsof" command from busybox does not support "-p" option and just list all open files for all process (see discussion [1])
>>> 
>>> The proposed fix checks not only that result of "lsof -f" command contains the GC log file but also that it has the child pid:
>>> 
>>> http://cr.openjdk.java.net/~alexsch/portola/TestInheritFD/webrev.00/
>>> 
>>> This does not work work for Solaris "pfiles -F" so the additional flag is added that the pid is only checked for "lsof".
>>> 
>>> Another proposed options was to check open files for a process by "ls -l /proc/$$/fd". It seems it also is not directly applied for Solaris.
>>> 
>>> [1] https://urldefense.com/v3/__https://www.openwall.com/lists/musl/2020/02/08/3__;!!GqivPVa7Brio!MrRAJpFUS00tP2rnLyb-AEvfvItl5wYpw2ufPuRaZHpbBxjhS6vP29kJ4FoIFxC35ZBp$ <https://urldefense.com/v3/__https://www.openwall.com/lists/musl/2020/02/08/3__;!!GqivPVa7Brio!MrRAJpFUS00tP2rnLyb-AEvfvItl5wYpw2ufPuRaZHpbBxjhS6vP29kJ4FoIFxC35ZBp$> 
>>> Thanks,
>>> 
>>> Alexandr.



More information about the portola-dev mailing list