Fix for test/jdk/tools/launcher ExecutionEnvironment.java and Test7029048.java tests on Alpine Linux

[Mikael Vidstedt]

Thanks for making the changes. I’ll sponsor it for you.

Cheers,
Mikael

> On Feb 17, 2020, at 2:07 AM, Alexander Scherbatiy <alexander.scherbatiy at bell-sw.com> wrote:
> 
> On 15.02.2020 10:33, Mikael Vidstedt wrote:
> 
>> Would indeed be nice to share the isMusl() code, but not sure it’s possible..
>> 
>> By adding the “!isMusl” check at the end of Test7029048.java you’re effectively disabling the “passes” check for musl. Should that logic instead be updated to check the expected number of passes on musl?
> 
> Here is the updated version:
> 
> http://cr.openjdk.java.net/~alexsch/portola/tests/launcher/webrev.01 <http://cr.openjdk.java.net/~alexsch/portola/tests/launcher/webrev.01>
> 
> Test7029048 has 3 test cases (LIBJVM, NO_LIBJVM, and NO_DIR). Each of which has 2 general checks and one special for Solaris. Only LIBJVM test case is applicable for musl and AIX.
> 
> So there are 9 tests for Solaris, 6 for Linux without musl and 2 for Linux with musl and AIX.
> 
>> Minor nit: "because the Aix and Musl launcher adds the paths in any case.” -> "because the Aix and Musl launchers add the paths in any case.”.
> 
> Updated.
> 
> Thanks,
> 
> Alexander.
> 
>> 
>> Cheers,
>> Mikael
>> 
>>> On Feb 14, 2020, at 2:20 AM, Alexander Scherbatiy <alexander.scherbatiy at bell-sw.com> wrote:
>>> 
>>> Hello,
>>> 
>>> 
>>> Two jdk/tools/launcher tests fail because they expect that the launcher does not pollute LD_LIBRARY_PATH.
>>> 
>>> This is not the case for Alpine Linux (more details are in the comment for RequiresSetenv() method from java_md_solinux.c [1]).
>>> 
>>> The proposed fix adds isMusl and isExpandedSharedLibraryPath flags to the TestHelper class to be able to check that LD_LIBRARY_PATH is modified because of the system requirements:
>>> 
>>> http://cr.openjdk.java.net/~alexsch/portola/tests/launcher/webrev.00
>>> 
>>> The code for isMuslLibc() is copied from VMProps.java jtreg extension which leads to the code duplication. May be it would be better to reuse the same method in both classes.
>>> 
>>> [1] https://urldefense.com/v3/__https://github.com/openjdk/portola/blob/93b8ad5f1ef3d2a260fa580db0113bb40db83a72/src/java.base/unix/native/libjli/java_md_solinux.c*L244__;Iw!!GqivPVa7Brio!JhUXDfFoTIf5Hr_0bDqgqkbOV9GSD0TzEfB379gM7IpuuxkEHqJD75JkoUtM4DIcEhSv$ <https://urldefense.com/v3/__https://github.com/openjdk/portola/blob/93b8ad5f1ef3d2a260fa580db0113bb40db83a72/src/java.base/unix/native/libjli/java_md_solinux.c*L244__;Iw!!GqivPVa7Brio!JhUXDfFoTIf5Hr_0bDqgqkbOV9GSD0TzEfB379gM7IpuuxkEHqJD75JkoUtM4DIcEhSv$> 
>>> 
>>> Thanks,
>>> 
>>> Alexander.