RFR: JEP 386 patch - minor cleanup

Alexander Scherbatiy alexsch at openjdk.java.net
Wed Sep 2 05:42:26 UTC 2020


On Tue, 1 Sep 2020 21:33:48 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> "JEP 386 patch - minor cleanup" changes discussed on portola-dev alias:
>> https://mail.openjdk.java.net/pipermail/portola-dev/2020-August/000471.html
>> 
>> Changed:
>> * RELEASE_FILE_OS_LIBC is introduced in make files
>> * glibc_version is renamed to libc_version
>> * added fix for numa_node_to_cpus NUMA method
>> * WhiteBox is used to check musl libc in tests
>> * Platform.isBusybox(tool) method is added to check busybox in tests
>> 
>> Removed:
>> * HOTSPOT_TARGET_LIBC flag
>> * workaround for issues for execvp file call in childproc.c file
>> * workaround for coredump issue in ps_core.c file
>> 
>> Skipped:
>> * isnanf change from globalDefinitions_gcc.hpp
>> * SIGRTMAX changes from NativeThread.c and linux_close.c files
>
> This all looks good. I'm trying to decide whether I should pull in jdk-16+13 before integrating this, so that we get
> the upstream fixes for isnanf and WAKEUP_SIGNAL first. Worst case that would mean you'd have to resolve conflicts, but
> it should be fairly straightforward. Thoughts?

Yes, let's integrate upstream fixes first and I will update the pull request with resolved confilicts.

-------------

PR: https://git.openjdk.java.net/portola/pull/12


More information about the portola-dev mailing list