RFR (M): 8019519: PPC64 (part 105): C interpreter: implement support for jvmti early return.

[serguei.spitsyn at oracle.com]

Hi Goetz,

The fix looks good in general.
Thank you for doing this!

A couple of comments:

src/share/vm/interpreter/bytecodeInterpreter.cpp:

It looks like you have accidentally dropped the line:

2981       THREAD->clr_pop_frame_in_process();


What is the reason that the following lines are deleted? (the same as 
Vladimir already asked):

2962       istate->set_return_kind((Bytecodes::Code)opcode);

2987     istate->set_return_kind((Bytecodes::Code)opcode);


Thanks,
Serguei

On 7/3/13 3:24 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> This change implements jvmti early return  and pop frame support
> in the cppInterpreter. To work properly, the corresponding properties in
> JvmtiManageCapabilities::init_onload_capabilities() must be enabled.
> We will add this in a later change.
>
> I would be happy about a review of this change:
> http://cr.openjdk.java.net/~goetz/webrevs/8019519-cInter_earlyRet/
>
> Best regards,
>    Goetz.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20130703/78abc201/attachment.html