RFR(S): 8019926 : PPC64 (part 106): Make hsdis build and work on Linux/PPC64

[Vladimir Kozlov]

Looks good.

Please, fix indention in hsdis.c.

Could you add workaround info to the src/share/tools/hsdis/README?

thanks,
Vladimir

On 7/24/13 10:39 AM, Volker Simonis wrote:
> Hi,
>
> could you please review the following small patch which enables
> building the hsdis library on Linux/PPC64 and AIX/PPC64:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8019926/
>
> I've tested that this change will not break the Linux/x86/x86_64 and
> Solaris/sparc/sparcv9 platforms.
>
> Notice that building the hs-dis library against a recent source
> version of binutils may stop because of a dependency bug in the
> binutils configure/make system with an error like:
>
> WARNING: `makeinfo' is missing on your system.  You should only need it if
>           you modified a `.texi' or `.texinfo' file, or any other file
>           indirectly affecting the aspect of the manual.  The spurious
>           call might also be the consequence of using a buggy `make' (AIX,
>           DU, IRIX).  You might want to install the `Texinfo' package or
>           the `GNU make' package.  Grab either from any GNU archive site.
> make[4]: *** [bfd.info] Error 1
>
> The easiest way to work around this problem is by doing a "touch
> $BINUTILS/bfd/doc/bfd.info". I've documented this in the HotSpot Wiki
> at:
>
> https://wiki.openjdk.java.net/display/HotSpot/PrintAssembly
>
> Thank you and best regards,
> Volker
>