JEP 175 - Review comments

[Volker Simonis]

Not sure, but maybe hotspot-dev is the best in this case.
Then at least nobody can complain that he didn't knew about the changes
later on:)


On Tuesday, June 11, 2013, Vladimir Kozlov wrote:

> Forgot to include ppc-aix mail alias. Which Hotspot mail alias we will use
> for reviews?
>
> Thanks,
> Vladimir
>
>
> -------- Original Message --------
> Subject: Re: JEP 175 - Review comments
> Date: Tue, 11 Jun 2013 09:33:59 -0700
> From: Vladimir Kozlov <vladimir.kozlov at oracle.com>
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> CC: Volker Simonis <volker.simonis at gmail.com>,  Azeem Jiva <
> azeem.jiva at oracle.com>, Chris Plummer <chris.plummer at oracle.com>
>
> Here is result of my first attempt to build/test ppc changes together
> with our closed sources.
>
> Small problems:
>
> src/share/vm/memory/**allocation.hpp:209: Trailing whitespace
> src/share/vm/memory/**allocation.inline.hpp:121: Trailing whitespace
> src/share/vm/opto/escape.cpp:**2207: Trailing whitespace
> src/share/vm/memory/**allocation.hpp:212: Trailing whitespace
> src/share/vm/opto/escape.cpp:**2214: Trailing whitespace
>
> Build on MacOS:
>
> src/share/vm/opto/**callGenerator.cpp: In member function 'virtual
> JVMState* VirtualCallGenerator::**generate(JVMState*)':
> src/share/vm/opto/**callGenerator.cpp:204: error:
> 'zero_page_read_protected' is not a member of 'os'
>
> agent/src/os/bsd/**MacosxDebuggerLocal.m:54:2: error: #error
> UNSUPPORTED_ARCH
> agent/src/os/bsd/**MacosxDebuggerLocal.m:167:4: error: #error
> UNSUPPORTED_ARCH
> agent/src/os/bsd/**MacosxDebuggerLocal.m:591:2: error: #error
> UNSUPPORTED_ARCH
>
>
> We have several conflict with closed sources builds:
>
> src/share/vm/utilities/**elfSymbolTable.cpp: In member function 'bool
> ElfSymbolTable::lookup(**unsigned char*, int*, int*, int*)':
> src/share/vm/utilities/**elfSymbolTable.cpp:97: error: comparison between
> signed and unsigned integer expressions
> src/share/vm/utilities/**elfSymbolTable.cpp:124: error: comparison between
> signed and unsigned integer expressions
>
> error: no 'oopDesc** frame::interpreter_frame_**mirror_addr() const'
> member function declared in class 'frame'
>
> error: no matching function for call to
> 'SharedRuntime::c_calling_**convention(BasicType*&, VMRegPair*&, uint&)'
>
> I think it is due to changes like next:
>
> -#ifdef PPC
> +#ifdef PPC32
>    oop* interpreter_frame_mirror_addr(**) const;
>
>
> Next is easy fix in our closed sources but it requires efforts from our
> side:
>
> src/share/vm/prims/**methodHandles.cpp: In static member function 'static
> void MethodHandles::generate_**adapters()':
> src/share/vm/prims/**methodHandles.cpp:68: error: 'adapter_code_size'
> cannot be used as a function
> src/share/vm/prims/**methodHandles.cpp:70: error: 'adapter_code_size'
> cannot be used as a function
>
>
> I would suggest to do such shared changes which affects different builds
> later after initial push.
>
>
> Thanks,
> Vladimir
>
> On 6/7/13 3:20 AM, Lindenmaier, Goetz wrote:
>
> Hi Vladimir,
>
> I updated the repo to jdk8-b92.  Our nightly tests built and
> tested it successfully.  In case you experience any problems
> please tell me the details so I can fix them.
>
> Best regards,
>    Goetz.
>
> http://cr.openjdk.java.net/~**simonis/ppc-aix-port/index.**html<http://cr.openjdk.java.net/~simonis/ppc-aix-port/index.html>
>
>
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Dienstag, 4. Juni 2013 20:58
> To: Simonis, Volker
> Cc: Iris Clark; Wintergerst, Michael; Lindenmaier, Goetz; Bernard
> Traversat; Jeannette Hung; Azeem Jiva; David Therkelsen; Mikael Vidstedt;
> Neil Richards; Steve Poole; luchsh at cn.ibm.com; Tim Ellison; Alan Bateman
> Subject: Re: JEP 175 - Review comments
>
> Volker,
>
> Can you or someone update
> http://hg.openjdk.java.net/**ppc-aix-port/jdk8/hotspot<http://hg.openjdk.java.net/ppc-aix-port/jdk8/hotspot>to match latest
> sources in http://hg.openjdk.java.net/**jdk8/jdk8/hotspot<http://hg.openjdk.java.net/jdk8/jdk8/hotspot>
> ?
> I just tried to merge them and build Hotspot on x86 without success.
>
> Thanks,
> Vladimir
>
> On 6/4/13 7:04 AM, Simonis, Volker wrote:
>
>
> We intentionally used 'porters-dev' rather than'ppc-aix-port-dev' in the
> beginning to address a broader audience for the initial discussions.
>
> But I'm happy to change that back to 'ppc-aix-port-dev' now.
>
> Regards,
> Volker
>
>
> ------------------------------**------------------------------**
> ------------<
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20130611/6fb17ec8/attachment.html