RFR(M): 8016586: PPC64 (part 3): basic changes for PPC64

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Jun 13 15:38:25 PDT 2013


Hi,

http://cr.openjdk.java.net/~goetz/webrevs/8016586-inlcudes/

This change contains the #includes we need for the linuxppc64 port,
and some other minor changes.  It decides about the
file names in the cpu/ppc directory. 

We changed some of your #includes to use _32 extension, basically
where they are guarded by TARGET_ARCH_MODEL... .  I think it 
would make sense to set TARGET_ARCH_MODEL_ppc_32 instead
of TARGET_ARCH_MODEL_ppc in your port, and name all files used 
within that define with extension _32. In the webrev this is changed 
consistently (not so in the patch).

What are your politics about ordering the includes here? Most 
other includes are alpha sorted, but the platforms here are not
at all. If you wish to, I'll establish a certain order.

The changes in compileBroker.cpp and globals.hpp/EnableInvokeDynamic
are preliminary. They'll be reverted in later changes.

I would be glad if you could review this change,

Best regards & thanks,
  Goetz.


More information about the ppc-aix-port-dev mailing list