RFR(M): 8016586: PPC64 (part 3): basic changes for PPC64

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Jun 14 13:54:12 PDT 2013


Hi Vladimir, 

I put the answer into a reply on this thread, if that's ok.

> Albert tried 3 together with 1+2 and it failed to build very 
> dramatically so I need to look what happens.
> It could be because you use TARGET_ARCH_MODEL_ppc_32 but 
> make/linux/platform_ppc was not modified accordingly so the build still 
> use TARGET_ARCH_MODEL_ppc.

I guess you have to set arch_model = ppc_32 in platform_ppc.
Further I renamed 
   interp_masm_ppc_32.hpp
   stubRoutines_ppc_32.hpp
I assume that adlc automatically adapts the names, or better the
adlc.make does so.
I'm not sure whether you need a ppc_32.ad file.  I needed one (ppc_64.ad), 
which is empty so far.

Best regards,
  Goetz.



-----Original Message-----
From: goetz.lindenmaier at sap.com 
Sent: Friday, June 14, 2013 12:38 AM
To: 'Vladimir Kozlov'
Cc: 'David Holmes'; 'ppc-aix-port-dev at openjdk.java.net'; 'Chris Plummer'; 'hotspot-dev at openjdk.java.net'
Subject: RFR(M): 8016586: PPC64 (part 3): basic changes for PPC64

Hi,

http://cr.openjdk.java.net/~goetz/webrevs/8016586-inlcudes/

This change contains the #includes we need for the linuxppc64 port,
and some other minor changes.  It decides about the
file names in the cpu/ppc directory. 

We changed some of your #includes to use _32 extension, basically
where they are guarded by TARGET_ARCH_MODEL... .  I think it 
would make sense to set TARGET_ARCH_MODEL_ppc_32 instead
of TARGET_ARCH_MODEL_ppc in your port, and name all files used 
within that define with extension _32. In the webrev this is changed 
consistently (not so in the patch).

What are your politics about ordering the includes here? Most 
other includes are alpha sorted, but the platforms here are not
at all. If you wish to, I'll establish a certain order.

The changes in compileBroker.cpp and globals.hpp/EnableInvokeDynamic
are preliminary. They'll be reverted in later changes.

I would be glad if you could review this change,

Best regards & thanks,
  Goetz.


More information about the ppc-aix-port-dev mailing list