RFR(S): 8017313: PPC64 (part 6): cppInterpreter: stack handling improvements

[Bertrand Delsart]

This is used also for the templateInterpreter.

We indeed compute the _stack_limit for all interpreter overflow checks
(from _stack_base and _stack_size). Not sure this is worth optimizing if 
it requires an extra field and benefits only the interpreters.

On the other hand, stack_base() is probably very rarely used in critical 
paths. Would it be worth replacing the _stack_base field by a 
_stack_limit field (recomputing stack_base() from _stack_limit and 
_stack_size) ?

Regards,

Bertrand.

On 06/25/13 02:52 PM, David Holmes wrote:
> Hi Goetz,
>
> This does not sit well with me. Convince me why we should saddle all
> builds with this only to support the cppInterpreter?
>
> Thanks,
> David
>
> On 25/06/2013 10:44 PM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> We precompute the stack limit for overflow checks and save this
>> limit in the thread.  This simplifies the assembler coding checking
>> the stack overflow. This change contains the necessary shared
>> functionality. It can easily be ported to other platforms, too.
>> http://cr.openjdk.java.net/~goetz/webrevs/8017313-stack/
>>
>> Please review this change.
>>
>> Best regards,
>>    Goetz.
>>
>> PS: I removed some parts of patch 0006 because I found a better
>> platform-only solution.
>>


-- 
Bertrand Delsart,                     bertrand.delsart at oracle.com
Oracle,         180 av. de l'Europe,          ZIRST de Montbonnot
38334 Saint Ismier,                                        FRANCE
Phone : +33 4 76 18 81 23

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact
the sender by reply email and destroy all copies of the original
message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~