RFR(M): 8024921: PPC64 (part 113): Extend Load and Store nodes to know about memory ordering.

[Vitaly Davidovich]

Hi Goetz,

Just curious - why an enum for both versions (load, store) and not a simple
bool? You expecting more values? You wouldn't need those asserts in the
accessors if this was a bool.

Also what does "Sem" stand for? Semantic? Seems like an odd abbreviation.

Thanks

Sent from my phone
On Nov 12, 2013 11:31 AM, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
wrote:

> Hi,
>
> I updated this webrev to work with the latest version of the staging
> repository.
> http://cr.openjdk.java.net/~goetz/webrevs/8024921-0-ldst/
>
> Best regards,
>   Goetz.
>
> From: goetz.lindenmaier at sap.com
> Sent: Freitag, 11. Oktober 2013 15:34
> To: hotspot-dev developers; ppc-aix-port-dev at openjdk.java.net; Vladimir
> Kozlov
> Subject: RFR(M): 8024921: PPC64 (part 113): Extend Load and Store nodes to
> know about memory ordering.
>
> Hi,
>
> I prepared a webrev for 8024921<
> https://bugs.openjdk.java.net/browse/JDK-8024921>Extend Load and Store
> nodes to know about memory ordering.
> This is part of the PPC port.
> http://cr.openjdk.java.net/~goetz/webrevs/8024921-0-ldst/
>
> For a detailed description see the text in the webrev and bug description.
>
> All this basically does is add a field to load and store nodes and
> change all constructor calls to set this field.  So the effect on
> existing platforms should be very small.  Therefore I marked this
> 'M', although quite some lines of code are touched.
>
> Please review and test this change.
> I'm happy to incorporate your comments and any improvements
> you propose.
>
> Best regards,
>   Goetz.
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20131112/38c6dc17/attachment-0001.html