RFR (S): 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.

[Lindenmaier, Goetz]

Thank you!

Best regards,
  Goetz.

-----Original Message-----
From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] 
Sent: Friday, November 22, 2013 5:58 PM
To: Lindenmaier, Goetz; 'hotspot-dev at openjdk.java.net'; 'ppc-aix-port-dev at openjdk.java.net'
Subject: Re: RFR (S): 8029025: PPC64 (part 203): opto: Move static _in_dump_cnt to Compile object.

Looks good. Compile::current() is expensive but it is only for debugging. I will push it today.

Thanks,
Vladimir

On 11/22/13 7:39 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> I prepared a webrev containing some debugging support.
> http://cr.openjdk.java.net/~goetz/webrevs/8029025-0-ndmp/
>
> To allow some special cases when dumping debug information about IR
> nodes, _in_dump_cnt can be increased. Unfortunately this is a global
> field.  If running with more than one compiler thread races can happen.
> As consequence, dumping crashes e.g. in MachProjNode::adr_type().
>
> This change moves the field to the Compile object.
>
> It also introduces the compiler oracle 'option' feature for PrintAssembly.
>
> This is not a mandatory part of the port, but we find this very useful
> if debugging the compiler.
>
> Please review and test this change
>
> Best regards,
>    Goetz.
>