RFR(M): 8024265: Enable new build on AIX (jdk part)

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Sep 17 11:49:39 PDT 2013


Thumbs up. You can push it.

Thanks,
Vladimir

On 9/17/13 10:14 AM, Vladimir Kozlov wrote:
> Let me test the build with closed sources. If it passed you can push.
>
> Thanks,
> Vladimir
>
> On 9/17/13 5:43 AM, Volker Simonis wrote:
>> Hi Erik,
>>
>> thank for the review!
>>
>> On Tue, Sep 17, 2013 at 9:09 AM, Erik Joelsson
>> <erik.joelsson at oracle.com> wrote:
>>> Hello Volker,
>>>
>>> This looks good to me. I think the mapfile situation could be solved
>>> better,
>>> but your solution is probably the simplest, at least if you
>>> anticipate using
>>> them in the future.
>>
>> Yes, you're right. We still have to figure out the best way of
>> exporting/hiding symbols on AIX. But with the current solution at
>> least the build works without fine without big changes and we have
>> placeholders for AIX-specific export files if we should need them in
>> the future.
>>
>> Is it OK if I push this change (with the new BugID
>> https://bugs.openjdk.java.net/browse/JDK-8024900 created by Vladimir)
>> to the stage repository? As far as I can see, there are no closed
>> dependencies in this case.
>>
>> Thanks,
>> Volker
>>
>>>
>>> /Erik
>>>
>>>
>>> On 2013-09-16 17:20, Volker Simonis wrote:
>>>>
>>>> Hi,
>>>>
>>>> could you please review the following webrev which contains the changes
>>>> needed in the 'jdk' repository in order to build the OpenJDK on AIX:
>>>>
>>>> http://cr.openjdk.java.net/~simonis/webrevs/8024265_jdk/
>>>>
>>>> With this change and "8024854: Basic changes and files to build the
>>>> class
>>>> library on AIX
>>>> <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8024854>"
>>>>
>>>> it will be possible to configure and completely build the staging
>>>> repository on AIX 5.3 and 7.1 with the following command:
>>>>
>>>> configure --with-boot-jdk=<jdk-image> --with-jvm-variants=core
>>>> --with-jvm-interpreter=cpp --with-cups-include=/opt/freeware/include
>>>> --x-includes=/opt/freeware/include
>>>>
>>>> The webrev for 8024854 will follow within the next days...
>>>>
>>>> Below you can find the changes and additions I've done, sorted by file.
>>>> Most of them are just additions which are only active during the AIX
>>>> build
>>>> anyway or simple changes where AIX has been added to conditions which
>>>> already check for Linux and/or Solaris. Therefore, IMHO the impact
>>>> on the
>>>> existing platforms is really minimal.
>>>>
>>>> Thank you and best regards,
>>>> Volker
>>>>
>>>> make/tools/sharing/classlist.aix
>>>>
>>>>      - Add AIX-specific class list.
>>>>
>>>> makefiles/CompileJavaClasses.gmk
>>>>
>>>>      - Add corresponding AIX-files to the list of exclude files for
>>>> non-AIX
>>>>      builds.
>>>>
>>>> makefiles/CompileLaunchers.gmk
>>>>
>>>>      - Statically link libjli on AIX because xlc on AIX doesn't
>>>> support the
>>>>      -rpath option.
>>>>
>>>> makefiles/CompileNativeLibraries.gmk
>>>>
>>>>      - Add required flags for AIX (i.e. by specifying CFLAGS_aix and
>>>>      LDFLAGS_SUFFIX_aix).
>>>>      - Add corresponding AIX-files to the LIBATTACH_EXCLUDE_FILES
>>>> list of
>>>>
>>>>      exclude files for non-AIX builds.
>>>>      - Specify BUILD_LIBNIO_FILES and BUILD_LIBNIO_MAPFILE for the AIX
>>>> build.
>>>>      - Statically link libjli on AIX becasue xlc on AIX doesn't
>>>> support the
>>>>      -rpath option.
>>>>      - Specify -DX_PLATFORM=X_AIX in the LIBJSOUND_CFLAGS on AIX.
>>>>
>>>> makefiles/GendataFontConfig.gmk
>>>>
>>>>      - Specify AIX-specific fontconfig-settings.
>>>>
>>>> makefiles/GensrcX11Wrappers.gmk
>>>>
>>>>      - Use platform-independent $(COMPILER_TARGET_BITS_FLAG) variable
>>>>
>>>>      (introduced by change "8024265: Enable new build on AIX (top level
>>>> part)"<http://hg.openjdk.java.net/ppc-aix-port/stage/rev/584dc2e95e04>)
>>>>
>>>> instead of hard-coded
>>>>      -m option.
>>>>
>>>> makefiles/mapfiles/libattach/mapfile-aix,
>>>> makefiles/mapfiles/libnio/mapfile-aix
>>>>
>>>>      - Add currently unused but required dummy mapfiles for AIX build.
>>>
>>>


More information about the ppc-aix-port-dev mailing list