Merge of PPC port into IcedTea 2.x for OpenJDK 7

Tue Feb 4 10:55:59 PST 2014

On Tuesday, February 4, 2014, Andrew Hughes <gnu.andrew at redhat.com> wrote:

> ----- Original Message -----
> > Hi Andrew,
> >
> > in jdk8/9 we changed the line in elfSymbolTable.cpp to
> >         if (sym_addr <= addr && (Elf_Word)(addr - sym_addr) < st_size) {
>
> Ah, yeah that looks like the fix I need :)
>
> Still a bit baffled because, AFAICS, elf.h defines both Elf32_Word and
> Elf64_Word as unsigned 32-bit integers, so I imagine the difference is in
> the result of (addr - sym_addr) (i.e. the type of address).
>
> Funny, I was just pulling the jdk9 repos as I saw this. It doesn't seem
> to have appeared in 8 yet.

The situation is a little complicated:)

ppc-aix-port/jdk8 and ppc-aix-port/stage-9 are closed.

ppc-aix-port/stage was initially used to hold the reviewed (and potentially
modified) changes of ppc-aix-port/jdk8. Later, ppc-aix-port/stage-9 was
cloned from ppc-aix-port/stage and synced with jdk9/dev until we finally
merged it into jdk9/dev (jdk part) and jdk9/hs-comp (complete port).

So currently, jdk9/hs-comp contains the most up to date version of the
port. ppc-aix-port/stage is just a little behind. It is synced against
jdk8/jdk8u and will be finally merged into it. This is planned for March
and should be early enough such that the port will make it into 8u20. After
that merge ppc-aix-port/stage will be closed as well.

> >
> > Does it help you if I apply the fixes you did in icedtea to the jdk7u
> > repository?
> > I also thought of bringing some of the reviewed jdk8/9 changes to 7u, at
> > least
> > as far as they do work there.  The elf change would be a candidate.
> >
>
> I guess it depends on how much you intend to further maintain the ppc jdk7u
> tree. If we're going to need to do further merges down the track, then it
> would certainly help if they are as in sync as possible.
>
> > Best regards,
> >   Goetz.
> >
> >
> > -----Original Message-----
> > From: ppc-aix-port-dev-bounces at openjdk.java.net
> > [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of Andrew
> > Hughes
> > Sent: Dienstag, 4. Februar 2014 17:01
> > To: Volker Simonis
> > Cc: ppc-aix-port-dev at openjdk.java.net
> > Subject: Re: Merge of PPC port into IcedTea 2.x for OpenJDK 7
> >
> > ----- Original Message -----
> > > Hi Andrew,
> > >
> > > nice to hear that we're finally getting consumed :)
> >
> > I've been wanting to look at this since it was first announced, but it's
> > just a matter of finding the time! :)
> >
> > >
> > > We regularly build and test on boxes with IBM's Power 5,6 and 7 CPUs.
> > > So on these machines there should be no problems. What other 64-bit
> > > Power machines do you think of?
> >
> > I was thinking of the PPC970 which was used in Apple's PowerMacs, mainly
> > because I still have one hanging around. But I suspect it's easy enough
> > and rare enough for someone using that to just explicitly enable Zero.
> > I guess we'll find out when distros start picking it up.
> >
> > >
> > > Recently, some folks from Servergy started to test our port on their
> > > new e6500 CPUs. Monica Beckwith from Servergy will be at FOSDEM so I
> > > hope we can have a chat there.
> > >
> >
> > Sorry I couldn't make FOSDEM. Just not enough funding for everyone
> > this time around :(
> >
> > > If you run a debug version of java with the "–XX:+Verbose" flag, the
> > > VM will print the extra instructions it detected and it thinks are
> > > available on your machine. In general we only use Power5 instructions
> > > plus the one we detected. If you run on hardware older than Power5, we
> > > may have to do some more probing, but we don't have such machines. If
> > > you encounter any problems, please let us know.
> > >
> >
> > I was hoping for something that could be tested by autoconf's configure
> > script before the build happens (so we can then auto-enable Zero), but
> > I couldn't see anything obvious in /proc/cpuinfo and it's not a big
> issue.
> >
> > We did find a couple of issues with Zero at build-time that were easy
> > enough to fix:
> >
> > http://icedtea.classpath.org/hg/icedtea7-forest/hotspot/rev/b05adee3c184
> >
> > mostly just the change in signature of a function and the use of
> > InlineSmallCode
> > which was previously only used when the JIT was enabled.
> >
> > I haven't done any runtime testing yet though, so there may be other
> issues.
> >
> > I'm currently hitting this on x86:
> >
> >
> /builddir/build/BUILD/java-1.7.0-openjdk-1.7.0.60-2.5.0pre.2.fc21.i386/openjdk/hotspot/src/share/vm/utilities/elfSymbolTable.cpp:97:53:
> > error: comparison between signed and unsigned integer expressions
> > [-Werror=sign-compare]
> >          if (sym_addr <= addr && (addr - sym_addr) < st_size) {
> >                                                      ^
> >
> /builddir/build/BUILD/java-1.7.0-openjdk-1.7.0.60-2.5.0pre.2.fc21.i386/openjdk/hotspot/src/share/vm/utilities/elfSymbolTable.cpp:124:55:
> > error: comparison between signed and unsigned integer expressions
> > [-Werror=sign-compare]
> >            if (sym_addr <= addr && (addr - sym_addr) < st_size) {
> >                                                        ^
> > cc1plus: all warnings being treated as errors
> >
> > which I assume is due to one of the types being signed or not on x86 as
> > opposed
> > to other platforms. Digging into it now.
> >
> > Once it builds on all platforms, it'll be in Fedora rawhide and there
> should
> > be a corresponding IcedTea release soon, where other distros will also
> pick
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20140204/688fa5fc/attachment-0001.html 