RFR[9](S): 8036777: AIX: Adapt implementation after '6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris..'

[Volker Simonis]

Hi David,


that's a good question! I dug in our repos and asked around and it
seems that this is in the port port since the very first days for now
unknown reasons. I removed it in our internal version and if we don't
see any regressions I'll remove it from the OpenJDK port as well.

Thanks for pointing this out,
Volker


On Fri, Mar 7, 2014 at 5:14 AM, David Holmes <david.holmes at oracle.com> wrote:
> Hi Volker,
>
> I see Vladimir is already pushing this. It looks okay to me too.
>
> Aside: I was surprised to see this:
>
>  889 bool os::create_thread(Thread* thread, ThreadType thr_type, size_t
> stack_size) {
>  890
>  891   // We want the whole function to be synchronized.
>  892   ThreadCritical cs;
>
> Why do you need to serialize thread creation?
>
> David
> -----
>
>
> On 7/03/2014 1:09 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> could you please review and push the following little AIX-only change
>> which adapts the refactorings of  '6546236: Thread interrupt() of
>> Thread.sleep() can be lost on Solaris..' to AIX:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8036777/
>> https://bugs.openjdk.java.net/browse/JDK-8036777
>>
>> The change removes the implementations of os::sleep(), os::interrupt()
>> and os::is_interrupted() from os_aix.cpp such that AIX now uses the
>> implementations from os_posix.cpp like the other Unix platfroms and
>> defines os::supports_monotonic_clock() in os_aix.inline.hpp.
>>
>> Thank you and best regards,
>> Volker
>>
>