RFR(L): 8036976: PPC64: implement the template interpreter

[Vladimir Kozlov]

And we can change this check to something else in ppc64le changes if we 
want. I was concern that we will forgot about that place.

Vladimir

On 3/13/14 12:32 PM, Vladimir Kozlov wrote:
> On 3/12/14 10:04 PM, David Holmes wrote:
>> So we're assuming the ppc64le stuff will go in as a distinct
>> architecture after all ???
>>
>> In my opinion this fix should not have the ppc64le change - it should be
>> added if/when the ppc64le stuff gets accepted and pushed.
>
> I suggested it. From one side, yes ARCH should reflect architecture. But
> on other side, in reality, in our makefiles ARCH is a string returned by
> 'uname':
>
> #   ARCH      - uname output
> ARCH := $(shell uname -m)
>
> And it is the only way to see if it is pp64le. We can rename ARCH to
> UNAME_OUTPUT to avoid confusion but it is a different issue.
>
> Thanks,
> Vladimir
>
>>
>> David
>>
>> On 13/03/2014 5:25 AM, Vladimir Kozlov wrote:
>>> Looks fine to me. I will push it wiht me and Coleen as reviewers.
>>> I assume I need to push it into ppc-aix 8u stage repo. Right?
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 3/12/14 4:04 AM, Lindenmaier, Goetz wrote:
>>>> Hi Vladimir,
>>>>
>>>> thanks for the hint with the makefile -- that would have popped up
>>>> soon after I guess.
>>>>
>>>> I fixed that and the Copyright, and updated the webrev.
>>>> http://cr.openjdk.java.net/~goetz/webrevs/8036976-0-ti/
>>>>
>>>> Best regards,
>>>>    Goetz.
>>>>
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
>>>> Sent: Mittwoch, 12. März 2014 00:12
>>>> To: Lindenmaier, Goetz; 'hotspot-dev at openjdk.java.net';
>>>> 'ppc-aix-port-dev at openjdk.java.net'
>>>> Subject: Re: RFR(L): 8036976: PPC64: implement the template interpreter
>>>>
>>>> Hi Goetz,
>>>>
>>>> Should you also check for ppc64le?:
>>>>
>>>> ifeq ($(ARCH), ppc64)
>>>>     FORCE_TIERED=0
>>>>
>>>> Please, update year in Oracle copyright line in new files:
>>>>
>>>> Copyright (c) 1997, 2010, Oracle
>>>>
>>>> to
>>>>
>>>> Copyright (c) 2014, Oracle
>>>>
>>>> I know that you copied and modified from our existing files but HG
>>>> history does not show it anyway and they all looks new. We should have
>>>> done it for all ppc files but it is different issue.
>>>>
>>>> These changes passed JPRT build with our closed sources.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 3/11/14 2:37 PM, Lindenmaier, Goetz wrote:
>>>>> Hi,
>>>>>
>>>>> I had missed all the new files in the webrev.  I updated it with the
>>>>> files in it.
>>>>>
>>>>> Sorry for this trouble,
>>>>>     Goetz.
>>>>>
>>>>> From: Lindenmaier, Goetz
>>>>> Sent: Tuesday, March 11, 2014 10:13 AM
>>>>> To: hotspot-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
>>>>> Subject: RFR(L): 8036976: PPC64: implement the template interpreter
>>>>>
>>>>> Hi,
>>>>>
>>>>> This time I have a really nice one: the template interpreter for
>>>>> ppc64!
>>>>> Great thanks to my colleagues, especially Axel and Martin, who ported
>>>>> this.
>>>>> http://cr.openjdk.java.net/~goetz/webrevs/8036976-0-ti/
>>>>>
>>>>> With this change, both interpreters can be used on linux_ppc64 and
>>>>> aix_ppc64.
>>>>>
>>>>> This change almost only touches ppc platform files.
>>>>>
>>>>> I shared files, I needed to add a special case for PPC64 in
>>>>> make/linux/Makefile, as I found no way to set FORCE_TIERED=0 in any
>>>>> ppc file that's included above the use of FORCE_TIERED. As we don't
>>>>> have C1, the current scheme does not work for ppc64.
>>>>>
>>>>> Actually, one should have lines as
>>>>>      supports_cppInterpreter = 1
>>>>>      supports_c2 = 1
>>>>>      supports_c1 = 0
>>>>> in platform_<cpu>. But that's out of scope of this change.
>>>>>
>>>>> Further I add a #include in
>>>>> src/share/vm/interpreter/templateTable.hpp.  That's all for shared
>>>>> changes.
>>>>> Please review and test this change.
>>>>>
>>>>> Best regards,
>>>>>     Goetz.
>>>>>