AIX makefiles

[Volker Simonis]

Hi Alejandro,

you are right, the AIX version is wrong. That's because it is based on
the Linux/Solaris version before they were fixed by "8007639:
Workaround for ccache in vm.make is incorrect":

-vm_version.o: CXXFLAGS += ${JRE_VERSION}
+CXXFLAGS/vm_version.o += ${JRE_VERSION}
+
+CXXFLAGS/BYFILE = $(CXXFLAGS/$@)
+
+# File specific flags
+CXXFLAGS += $(CXXFLAGS/BYFILE)

It would be great if you could integrate this fix together with your
other changes into the AIX version of vm.make (I've just verified that
it works on AIX). Would that be possible?

I think this didn't had any bad impact until now, because we don't use
ccache on AIX anyway. But of course it is better to get it right and
aligned with the other platform.

Thanks for catching this,
Volker


On Thu, Mar 20, 2014 at 7:43 AM, Alejandro E Murillo
<alejandro.murillo at oracle.com> wrote:
>
> Hi guys,
>
> I'm making some makefile changes to modify the hotspot version output in
> jdk9,
> and realized that on hotspot/make/[bsd,linux,solaris]/makefiles/vm.make,
> the following definition is done this way:
>
> # This is VERY important! The version define must only be supplied to
> vm_version.o
> # If not, ccache will not re-use the cache at all, since the version string
> might contain
> # a time and date.
> CXXFLAGS/vm_version.o += ${JRE_VERSION}
>
> but on hotspot/make/aix/makefiles/vm.make is done this way:
>
> # This is VERY important! The version define must only be supplied to
> vm_version.o
> # If not, ccache will not re-use the cache at all, since the version string
> might contain
> # a time and date.
> vm_version.o: CXXFLAGS += ${JRE_VERSION}
>
> note that vm_version.o is defined later on in those files:
>
> vm_version.o: $(filter-out vm_version.o,$(JVM_OBJ_FILES))
>
> so I suspect that's a typo, right? or is that the way it works on aix?
>
> --
> Alejandro
>