RFR(xs): 8144343: [aix] Stack bottom should be page aligned

Thomas Stüfe thomas.stuefe at gmail.com
Wed Dec 2 15:49:10 UTC 2015


Hi Volker,

thank you for the review!

I changed the offending comments:

http://cr.openjdk.java.net/~stuefe/webrevs/8144343-aix-stack-bottom-align/webrev.01/webrev/

Kind Regards, Thomas

On Wed, Dec 2, 2015 at 4:32 PM, Volker Simonis <volker.simonis at gmail.com>
wrote:

> Hi Thomas,
>
> the change looks good. Just some minor comments (regarding the comments :)
>
> - what's the meaning of the comment (i.e. the question marks) in line 4348
>
> 4348   // high addr    ---------------------   real base ? at page border ?
>
> - you removed the link from line 4342 so please also remove "see also"
> from line 4350.
>
> Thanks,
> Volker
>
>
>
> On Wed, Dec 2, 2015 at 4:03 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> > Hi all,
> >
> > please review this tiny AIX-only fix. Basically, it takes care of the
> > thread stack bottom - and hence the placement of the guard pages - to be
> > always aligned to os::vm_page_size() .
> >
> > bug: https://bugs.openjdk.java.net/browse/JDK-8144343
> > webrev:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8144343-aix-stack-bottom-align/webrev.00/webrev/
> >
> > Kind Regards, Thomas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20151202/b11d8612/attachment.html>


More information about the ppc-aix-port-dev mailing list