RFR: 8144885: agent/src/os/linux/libproc.h needs to support Linux/SPARC builds

[Alexander Smundak]

It works for the little-endian PPC64 (actually, asm/ptrace.h will be
included anyway, regardless of the change).

On Thu, Dec 10, 2015 at 9:34 AM, Mikael Vidstedt
<mikael.vidstedt at oracle.com> wrote:
>
> It would surprise me (but probably shouldn't) if this breaks on ppc64, but -
> hey, ppc64 guys, this work for you? :)
>
> http://cr.openjdk.java.net/~mikael/webrevs/8144885/webrev.01/webrev
>
> Cheers,
> Mikael
>
> On 2015-12-09 21:09, David Holmes wrote:
>>
>> On 10/12/2015 8:28 AM, Dmitry Samersoff wrote:
>>>
>>> Mikael,
>>>
>>> Looks good for me.
>>>
>>> Hope it doesn't brake ppc64 build.
>>
>>
>> This needs to be checked with ppc64 folk first I think - else modified to
>> not affect ppc64.
>>
>> Thanks,
>> David
>>
>>> -Dmitry
>>>
>>> On 2015-12-10 00:49, Mikael Vidstedt wrote:
>>>>
>>>>
>>>> Right, I think that's the way to go. I suggest the following change:
>>>>
>>>> http://cr.openjdk.java.net/~mikael/webrevs/8144885/webrev.01/webrev
>>>>
>>>> Cheers,
>>>> Mikael
>>>>
>>>> On 2015-12-09 13:01, Dmitry Samersoff wrote:
>>>>>
>>>>> Mikael,
>>>>>
>>>>>> It simply doesn't export the type we need on SPARC (struct pt_regs or
>>>>>> whatever it's called, I don't have the code in front of me right
>>>>>> now). I don't know why, it simply doesn't :)
>>>>>
>>>>> For this case, please include <asm/ptrace.h> rest of code
>>>>> used to it.
>>>>>
>>>>> -Dmitry
>>>>>
>>>>>
>>>>> On 2015-12-09 08:58, Mikael Vidstedt wrote:
>>>>>>>
>>>>>>> On Dec 8, 2015, at 20:08, David Holmes <david.holmes at oracle.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On 9/12/2015 4:05 AM, Mikael Vidstedt wrote:
>>>>>>>>
>>>>>>>> The problem is that this needs to be backporting to jdk8u where
>>>>>>>> there is no devkit, and more importantly, even if there were I
>>>>>>>> believe we would see the same issue: the types needed are not
>>>>>>>> made available by including sys/ptrace.h on this platform. I
>>>>>>>> believe we can choose between linux/ptrace.h or asm/ptrace.h. The
>>>>>>>> former feels slightly better.
>>>>>>>
>>>>>>> Sorry I'm not convinced. What is the issue with using sys/ptrace.h
>>>>>>> (which should exist on your build platforms and your devkit)?
>>>>>>
>>>>>> It simply doesn't export the type we need on SPARC (struct pt_regs or
>>>>>> whatever it's called, I don't have the code in front of me right
>>>>>> now). I don't know why, it simply doesn't :)
>>>>>>
>>>>>> Cheers, Mikael
>>>>>>
>>>>>>> Thanks, David
>>>>>>>
>>>>>>>> Cheers, Mikael
>>>>>>>>
>>>>>>>>> On Dec 8, 2015, at 03:15, Dmitry Samersoff
>>>>>>>>> <dmitry.samersoff at oracle.com> wrote:
>>>>>>>>>
>>>>>>>>> Jerry,
>>>>>>>>>
>>>>>>>>>> In which case the devkit needs fixing I think, not the code.
>>>>>>>>>
>>>>>>>>> I'm second to David.
>>>>>>>>>
>>>>>>>>> It's better to not include linux/* headers explicitly.
>>>>>>>>>
>>>>>>>>> -Dmitry
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>> On 2015-12-08 08:23, David Holmes wrote: On 8/12/2015 2:59
>>>>>>>>>>> PM, Gerald Thornbrugh wrote: Hi David,
>>>>>>>>>>>
>>>>>>>>>>> Yes, I believe this is a devkit issue.  Mikael and I have
>>>>>>>>>>> been working to get JDK9 building in JPRT with the lab
>>>>>>>>>>> Linux/SPARC machines that use a devkit and this change was
>>>>>>>>>>> needed. I will update the bug detailing this as a devkit
>>>>>>>>>>> issue.
>>>>>>>>>>
>>>>>>>>>> In which case the devkit needs fixing I think, not the code.
>>>>>>>>>>
>>>>>>>>>> Cheers, David
>>>>>>>>>>
>>>>>>>>>>> Thanks!
>>>>>>>>>>>
>>>>>>>>>>> Jerry
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Jerry,
>>>>>>>>>>>>
>>>>>>>>>>>>> On 8/12/2015 8:58 AM, Gerald Thornbrugh wrote: Hi
>>>>>>>>>>>>> Everyone,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Please review this small change which fixes a JDK9
>>>>>>>>>>>>> Linux/SPARC build problem in
>>>>>>>>>>>>> "hotspot/agent/src/os/linux/libproc.h” so the correct
>>>>>>>>>>>>> “ptrace.h” include file will be used during the build
>>>>>>>>>>>>> process.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144885
>>>>>>>>>>>>> <https://bugs.openjdk.java.net/browse/JDK-8144885>
>>>>>>>>>>>>> Webrev:
>>>>>>>>>>>>> http://cr.openjdk.java.net/~gthornbr/8144885/webrev/
>>>>>>>>>>>>> <http://cr.openjdk.java.net/~gthornbr/8144885/webrev/>
>>>>>>>>>>>>
>>>>>>>>>>>> As far as I can see both versions of ptrace.h exist on
>>>>>>>>>>>> linux x86 and linux sparc distributions, so it is not at
>>>>>>>>>>>> all clear why this change is needed. Is it perhaps an
>>>>>>>>>>>> issue with a devkit?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks, David
>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Jerry
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -- Dmitry Samersoff Oracle Java development team, Saint
>>>>>>>>> Petersburg, Russia * I would love to change the world, but they
>>>>>>>>> won't give me the source code.
>>>>>
>>>>>
>>>>
>>>
>>>
>