RFR: JDK8u back port of JDK-8047763, JDK-8042059, JDK-8046408, JDK-8048232, JDK-8046471, JDK-8046611 and JDK-8044363

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Dec 18 18:47:59 UTC 2015


Greetings,

I'm sponsoring Jerry's backport of the Linux SPARC fixes to JDK8u.
As part of my sponsorship, I've separated the changes into distinct
changesets corresponding to the original JDK9 changesets. During
my sanity check, I noticed that the JDK-8048232 backport did not
exactly match the JDK9 version. Jerry had filtered out the PPC-32
bit portions of the change since they are not applicable to JDK8u.
Jerry and I have since decided that it is better to match the
original JDK9 changeset since the PPC-32 bit portions in the two
files will have no effect in JDK8u.

For the record, here's the diffs relative to Jerry's last webrev:

$ diff <jerry_path>/hotspot/webrev/raw_files/new/make/linux/Makefile 
hotspot/webrev/raw_files/new/make/linux/Makefile

73c73,75
<   FORCE_TIERED=0
---
 >   ifeq ($(ARCH_DATA_MODEL), 64)
 >     FORCE_TIERED=0
 >   endif


$ diff 
<Jerry_path>/hotspot/webrev/raw_files/new/make/linux/makefiles/defs.make 
hotspot/webrev/raw_files/new/make/linux/makefiles/defs.make

101c101
< # PPC64
---
 > # PPC
105,109c105,114
<   ARCH_DATA_MODEL  = 64
<   MAKE_ARGS        += LP64=1
<   PLATFORM         = linux-ppc64
<   VM_PLATFORM      = linux_ppc64
<   HS_ARCH          = ppc
---
 >   ifeq ($(ARCH_DATA_MODEL), 64)
 >     MAKE_ARGS        += LP64=1
 >     PLATFORM         = linux-ppc64
 >     VM_PLATFORM      = linux_ppc64
 >   else
 >     ARCH_DATA_MODEL  = 32
 >     PLATFORM         = linux-ppc
 >     VM_PLATFORM      = linux_ppc
 >   endif
 >   HS_ARCH = ppc


Mikael and Jerry,

Please confirm that you are good with these latest changes.

Dan


On 12/17/15 12:16 PM, Gerald Thornbrugh wrote:
> Hi Mikael,
>
> Thanks!
>
> Gerald
>>
>> Changes look good.
>>
>> This is touching PPC specific logic in the makefiles - the same logic 
>> I accidentally broke in the original change for[1], which resulted 
>> in[2]. I've cc:ed the PPC folks, hopefully they can help verify that 
>> this works as expected.
>>
>> Cheers,
>> Mikael
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8046471
>> [2] https://bugs.openjdk.java.net/browse/JDK-8048232
>>
>> On 2015-12-16 08:55, Gerald Thornbrugh wrote:
>>> Hi Everyone,
>>>
>>> I am back porting a series of JDK9 Linux/SPARC fixes to JDK8u so 
>>> Linux/SPARC is supported in JDK8.
>>>
>>> There are changes to three repositories - jdk8u, jdk8u/hotspot and 
>>> jdk8u/jdk.
>>>
>>> Here is the webrev:
>>>
>>> http://cr.openjdk.java.net/~gthornbr/linux-sparc-jdk8u/ 
>>> <http://cr.openjdk.java.net/~gthornbr/linux-sparc-jdk8u/>
>>>
>>> Here is a breakdown of the changes:
>>>
>>> jdk8u:
>>>
>>> These changes are related to changing the definition of “ARCH” 
>>> within the build process and adding
>>> the “sparc64” as a recognized platform.
>>>
>>> File Related CR
>>> common/autoconf/generated-configure.sh 
>>> https://bugs.openjdk.java.net/browse/JDK-8047763 
>>> <https://bugs.openjdk.java.net/browse/JDK-8047763>
>>> common/autoconf/hotspot-spec.gmk.in 
>>> https://bugs.openjdk.java.net/browse/JDK-8047763 
>>> <https://bugs.openjdk.java.net/browse/JDK-8047763>
>>> common/autoconf/platform.m4 
>>> https://bugs.openjdk.java.net/browse/JDK-8047763 
>>> <https://bugs.openjdk.java.net/browse/JDK-8047763>
>>>
>>>
>>> jdk8u/hotspot:
>>>
>>> These changes are related to including the correct include file, 
>>> using the new definition of “ARCH” and
>>> cleaning up debugging code that is outdated and difficult to support.
>>>
>>> The change for JDK-8046471 updated the value of the "ARCH" variable 
>>> used in the Hotspot makefiles
>>> from OPEN_TARGET_CPU_LEGACY to OPENJDK_TARGET_CPU_ARCH. Because of 
>>> this change
>>> some of the PPC uses of "ARCH" also needed to change. The PPC 
>>> portion of the fix was incorrect and
>>> had to be address by JDK-8048232 to make it work correctly.
>>>
>>> File Related CR
>>> hotspot/agent/src/os/linux/libproc.h 
>>> https://bugs.openjdk.java.net/browse/JDK-8042059 
>>> <https://bugs.openjdk.java.net/browse/JDK-8042059>
>>> https://bugs.openjdk.java.net/browse/JDK-8046408 
>>> <https://bugs.openjdk.java.net/browse/JDK-8046408>
>>> hotspot/make/linux/Makefile 
>>> https://bugs.openjdk.java.net/browse/JDK-8048232 
>>> <https://bugs.openjdk.java.net/browse/JDK-8048232>
>>> hotspot/make/linux/makefiles/defs.make 
>>> https://bugs.openjdk.java.net/browse/JDK-8046471 
>>> <https://bugs.openjdk.java.net/browse/JDK-8046471>
>>> https://bugs.openjdk.java.net/browse/JDK-8048232 
>>> <https://bugs.openjdk.java.net/browse/JDK-8048232>
>>> hotspot/src/cpu/sparc/vm/frame_sparc.cpp 
>>> https://bugs.openjdk.java.net/browse/JDK-8046611 
>>> <https://bugs.openjdk.java.net/browse/JDK-8046611>
>>> hotspot/src/vm/runtime/safepoint.cpp 
>>> https://bugs.openjdk.java.net/browse/JDK-8046611 
>>> <https://bugs.openjdk.java.net/browse/JDK-8046611>
>>>
>>>
>>> jdk8u/jdk:
>>>
>>> This change removed unneeded CFLAGS and LDFLAGS.
>>>
>>> File Related CR
>>> jdk/make/CompileLaunchers.gmk 
>>> https://bugs.openjdk.java.net/browse/JDK-8044363 
>>> <https://bugs.openjdk.java.net/browse/JDK-8044363>
>>>
>>>
>>>
>>> Please let me know if you have any questions or concerns.
>>>
>>> Gerald
>>
>
>



More information about the ppc-aix-port-dev mailing list