[9] RFR(XS): 8068505: interpreter profiling incorrect on PPC

[Zoltán Majó]

Thank you, Goetz, for the feedback!

Best regards,


Zoltan

On 01/08/2015 02:34 PM, Lindenmaier, Goetz wrote:
> Hi Zoltan,
>
> the change is good, thanks for spotting this!
>
> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of Zoltán Majó
> Sent: Dienstag, 6. Januar 2015 14:45
> To: ppc-aix-port-dev at openjdk.java.net
> Subject: [9] RFR(XS): 8068505: interpreter profiling incorrect on PPC
>
> Hi,
>
>
> I've recently looked at the PPC port in hotspot and I noticed the
> following small problem.
>
> Problem: The method
> TemplateInterpreterGenerator::generate_counter_incr() increments method
> invocations counters on all supported architectures, except on PPC (w/
> tiered compilation enabled). As a result, methods might be  compiled
> later and OSR happens sooner than specified by compilation thresholds.
>
> Solution: Change generate_counter_incr() in templateInterpreter_ppc.cpp
> to use invocation counters instead of backedge counters.
>
> Webrev: http://cr.openjdk.java.net/~zmajo/8068505/webrev.00/
>
> JDK Bug: https://bugs.openjdk.java.net/browse/JDK-8068505
>
> I was not able to test the change as I don't have access to appropriate
> infrastructure.
>
> Maybe this is the wrong list to send this RFR to. If yes, could you
> please tell me where to send it?
>
> Thank you and best regards,
>
>
> Zoltan
>