RFR (XS): 6313046: Remove unused frame::native_param_addr code

Chris Plummer chris.plummer at oracle.com
Tue Mar 10 22:59:55 UTC 2015


The set_link() removal looks good (thank you for taking care of this). 
Copyright year needs updating on all files.

cheers,

Chris

On 3/10/15 3:45 PM, Mikael Vidstedt wrote:
>
> New version:
>
> http://cr.openjdk.java.net/~mikael/webrevs/6313046/webrev.01/webrev/
>
> Changes since webrev.00:
>
> * Removed 
> native_frame_initial_param_offset/NATIVE_FRAME_INITIAL_PARAM_OFFSET
> * Removed set_link
> * Made corresponding changes for aarch64
> * Removed the vmStruct constant abi_minframe_size, the only usage 
> which was for NATIVE_FRAME_INITIAL_PARAM_OFFSET
>
> Cheers,
> Mikael
>
> On 2015-03-09 19:22, Chris Plummer wrote:
>> On 3/9/15 5:57 PM, Mikael Vidstedt wrote:
>>>
>>> Please review this small change which removes the unused/dead 
>>> frame::native_param_addr function along with the corresponding code 
>>> in the SA.
>>>
>>> http://cr.openjdk.java.net/~mikael/webrevs/6313046/webrev.00/webrev/
>>>
>>> Cheers,
>>> Mikael
>>>
>> Since you're removing unused frame APIs, maybe you can also remove 
>> frame::set_link(), which is also not used. I have no idea why it's 
>> there. Seems to be a very dangerous thing to do since the link 
>> (previous frame pointer) is setup by function prologue code, not by 
>> the JVM.
>>
>> cheers,
>>
>> Chris
>



More information about the ppc-aix-port-dev mailing list