RFR(m): 8140645: [aix] Recent Developments for AIX

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Oct 28 16:46:54 UTC 2015


Hi Thomas,

thanks for this cleanup, it's good to have the better version of 
loadlib in our port, too.  I'll sponsor this for you.

If I understand correctly, you also moved some utilities from porting_aix.* to new
files misc_aix.*.  That's fine. You missed the copyright message in misc_aix.cpp.

Please sort includes alphabetically.

Don't you want to move trcVerbose() to misc_aix, too?

Why do you choose buffer size 64 in debug builds in reload_table()?
Maybe write "size_t buflen = 64 NOT_DEBUG(*16);"

Please fix guarantee0 not to call assert. This was wrong before, 
probably added by me in the very beginning.

You mention TODO in loadlib_aix.cpp about the double stringlists.
As the other list (I assume you mean fixed_strings) is in aix coding
too, why don't you consolidate both in misc_aix.hpp?

I'll send you a patch with some formatting changes off-list. I think they 
fix some minor deviations from common coding style.  Feel free to 
apply them.

Best regards,
  Goetz.

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
Sent: Wednesday, October 28, 2015 12:09 PM
To: hotspot-runtime-dev at openjdk.java.net
Cc: ppc-aix-port-dev at openjdk.java.net
Subject: RFR(m): 8140645: [aix] Recent Developments for AIX

Hi,

please review and sponsor these AIX-only changes. These changes bring a
number of improvements to the AIX port which were originally developed at
SAP.

http://cr.openjdk.java.net/~stuefe/webrevs/8140645/webrev.00/webrev/index.html
https://bugs.openjdk.java.net/browse/JDK-8140645

Thank you!

Kind Regards, Thomas


More information about the ppc-aix-port-dev mailing list