RFR (XXS): 8162811: use correct IPv6 multicast socket options for AIX in PlainDatagramSocketImpl.c

[Langer, Christoph]

Hi Volker,

ok, I agree, I should probably hold back this merely cosmetical change for the moment and take a deeper look at the AIX multicast test failures and which fixes will be required.

Thanks
Christoph

> -----Original Message-----
> From: Volker Simonis [mailto:volker.simonis at gmail.com]
> Sent: Montag, 1. August 2016 10:23
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
> Subject: Re: RFR (XXS): 8162811: use correct IPv6 multicast socket options for
> AIX in PlainDatagramSocketImpl.c
> 
> Hi Christoph,
> 
> in general your change looks good, because the setsockopt man-page on
> AIX only defines IPV6_JOIN_GROUP/IPV6_LEAVE_GROUP but not
> IPV6_ADD_MEMBERSHIP/IPV6_DROP_MEMBERSHIP. On the other hand I was
> surprised that the original code compiled before. Looking into the AIX
> headers, I found:
> 
> #define IPV6_ADD_MEMBERSHIP     IP_ADD_MEMBERSHIP
> #define IPV6_JOIN_GROUP         IP_ADD_MEMBERSHIP
> #define IPV6_DROP_MEMBERSHIP    IP_DROP_MEMBERSHIP
> #define IPV6_LEAVE_GROUP        IP_DROP_MEMBERSHIP
> 
> As you can see, the two versions are equal on AIX and your change
> shouldn't change anything functionally.
> 
> So maybe we should wait with this cosmetic change and integrate it
> into the upcoming multicast cleanup/fix for AIX?
> On the other hand, if you absolutely want to push this fix you can
> consider it as reviewed.
> 
> Regards,
> Volker
> 
> 
> On Sat, Jul 30, 2016 at 7:54 AM, Langer, Christoph
> <christoph.langer at sap.com> wrote:
> > Hi,
> >
> >
> >
> > can you please review this very small change for AIX:
> >
> >
> >
> > diff -r 8730c04eac90 -r 6451c746c6d5
> > src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c
> >
> > --- a/src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c        Fri
> > Jul 29 19:00:54 2016 -0400
> >
> > +++ b/src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c        Sat
> > Jul 30 07:27:21 2016 +0200
> >
> > @@ -2223,7 +2223,7 @@
> >
> >              mname6.ipv6mr_interface = idx;
> >
> >          }
> >
> >
> >
> > -#if defined(_ALLBSD_SOURCE)
> >
> > +#if defined(_ALLBSD_SOURCE) || defined(_AIX)
> >
> > #define ADD_MEMBERSHIP          IPV6_JOIN_GROUP
> >
> > #define DRP_MEMBERSHIP          IPV6_LEAVE_GROUP
> >
> > #define S_ADD_MEMBERSHIP        "IPV6_JOIN_GROUP"
> >
> >
> >
> > Thanks
> >
> > Christoph
> >
> >