FW: RFR(XS): 8160565: AIX port: cleanup of libo4 wrapper stub

[Lindenmaier, Goetz]

Hi Christoph, 

you sent this for review to hotspot-runtime-dev.  So you should
have pushed this to jdk9/hs/hotspot.

Mailing list and repo are connected, so that people reading the list
also find the changes in the corresponding repo. Also, this is necessary
to avoid conflicts during merges in the weekly update.
 
hotspot-runtime-dev, hotspot-gc-dev ==> jdk9/hs/hotspot
hotspot-compiler-dev ==> jdk9/hs-comp/hotspot

Best regards,
  Goetz.

> -----Original Message-----
> From: Langer, Christoph
> Sent: Freitag, 1. Juli 2016 11:36
> To: Volker Simonis <volker.simonis at gmail.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>
> Cc: hotspot-runtime-dev at openjdk.java.net; ppc-aix-port-
> dev at openjdk.java.net
> Subject: RE: FW: RFR(XS): 8160565: AIX port: cleanup of libo4 wrapper stub
> 
> Thanks Volker and Goetz.
> 
> Pushed with your suggestions:
> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/adc8c84b7cf8
> 
> 
> > -----Original Message-----
> > From: Volker Simonis [mailto:volker.simonis at gmail.com]
> > Sent: Freitag, 1. Juli 2016 09:27
> > To: Langer, Christoph <christoph.langer at sap.com>
> > Cc: hotspot-runtime-dev at openjdk.java.net; ppc-aix-port-
> dev at openjdk.java.net
> > Subject: Re: FW: RFR(XS): 8160565: AIX port: cleanup of libo4 wrapper stub
> >
> > Hi Christoph,
> >
> > overall the change looks good.
> > Can you please just remove the logic from
> > libo4::removeEscapeMessageFromJoblogByContext() in libo4.cpp. As this
> > is a stub anyway, I think it is perfectly fine to simply return false.
> > There's no need to post a new webrev for that change.
> >
> > Thank you and best regards,
> > Volker
> >
> >
> > On Thu, Jun 30, 2016 at 2:31 PM, Langer, Christoph
> > <christoph.langer at sap.com> wrote:
> > > Forgot to include hotspot-runtime mailing list...
> > >
> > > -----Original Message-----
> > > From: Langer, Christoph
> > > Sent: Donnerstag, 30. Juni 2016 11:22
> > > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > > Cc: ppc-aix-port-dev at openjdk.java.net
> > > Subject: RE: RFR(XS): 8160565: AIX port: cleanup of libo4 wrapper stub
> > >
> > > Hi Goetz,
> > >
> > > I added this new structure, too:
> > http://cr.openjdk.java.net/~clanger/webrevs/8160565.2/
> > >
> > > Thanks
> > > Christoph
> > >
> > >
> > >> -----Original Message-----
> > >> From: Lindenmaier, Goetz
> > >> Sent: Donnerstag, 30. Juni 2016 08:24
> > >> To: Langer, Christoph <christoph.langer at sap.com>; ppc-aix-port-
> > >> dev at openjdk.java.net
> > >> Subject: RE: RFR(XS): 8160565: AIX port: cleanup of libo4 wrapper stub
> > >>
> > >> Hi Christoph,
> > >>
> > >> thanks for doing these changes, they look good.
> > >> Could you please also include the fixes we did in
> > >> Libperfstat_aix.hpp?
> > >>
> > >> Thanks,
> > >>   Goetz.
> > >>
> > >> > -----Original Message-----
> > >> > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> > >> > bounces at openjdk.java.net] On Behalf Of Langer, Christoph
> > >> > Sent: Mittwoch, 29. Juni 2016 18:28
> > >> > To: ppc-aix-port-dev at openjdk.java.net
> > >> > Subject: RFR(XS): 8160565: AIX port: cleanup of libo4 wrapper stub
> > >> >
> > >> > Hi,
> > >> >
> > >> >
> > >> >
> > >> > I made a little cleanup in the libo4 wrapper stubs to ease merging.
> > >> >
> > >> >
> > >> >
> > >> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8160565.1/
> > >> >
> > >> > Bug: https://bugs.openjdk.java.net/browse/JDK-8160565
> > >> > <https://bugs.openjdk.java.net/browse/JDK-8160565>
> > >> >
> > >> >
> > >> >
> > >> > Thanks
> > >> >
> > >> > Christoph
> > >> >
> > >> >
> > >