PPC64 VSX load/store instructions in stubs
Michihiro Horie
HORIE at jp.ibm.com
Tue May 31 15:46:35 UTC 2016
Hi Martin,
Thank you for fixing my code and uploading webrev. I sent a request with
the given title.
Best regards,
--
Michihiro Horie,
IBM Research - Tokyo
From: "Doerr, Martin" <martin.doerr at sap.com>
To: Michihiro Horie/Japan/IBM at IBMJP
Cc: Gustavo Romero <gromero at linux.vnet.ibm.com>, Miki M
Enoki/Japan/IBM at IBMJP, Breno Leitao <brenohl at br.ibm.com>,
"hotspot-dev at openjdk.java.net" <hotspot-dev at openjdk.java.net>,
"ppc-aix-port-dev at openjdk.java.net"
<ppc-aix-port-dev at openjdk.java.net>, "Simonis, Volker"
<volker.simonis at sap.com>, Volker Simonis
<volker.simonis at gmail.com>, Breno Leitao <brenohl at br.ibm.com>
Date: 2016/05/31 23:28
Subject: RE: PPC64 VSX load/store instructions in stubs
Hi Michihiro,
I have uploaded a webrev here:
http://cr.openjdk.java.net/~mdoerr/8158232_PPC_vsx_copy/webrev.00/
I had to change the formatting a little bit.
There was a
“src/cpu/ppc/vm/stubGenerator_ppc.cpp:1896: Trailing whitespace”
which is not allowed.
Please send out a request for review with the following subject and point
to the webrev:
"RFR(M): 8158232: PPC64: improve byte, int and long array copy stubs by
using VSX instructions"
Best regards,
Martin
From: Michihiro Horie [mailto:HORIE at jp.ibm.com]
Sent: Dienstag, 31. Mai 2016 13:51
To: Doerr, Martin <martin.doerr at sap.com>
Cc: Gustavo Romero <gromero at linux.vnet.ibm.com>; Miki M Enoki
<ENOMIKI at jp.ibm.com>; Breno Leitao <brenohl at br.ibm.com>;
hotspot-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; Simonis,
Volker <volker.simonis at sap.com>; Volker Simonis <volker.simonis at gmail.com>;
Breno Leitao <brenohl at br.ibm.com>
Subject: RE: PPC64 VSX load/store instructions in stubs
Hi Martin, Gustavo,
Thank you very much for your comments. I used VectorSRegisters, inserted an
if-statement with has_vsx() in long arraycopy, and moved the length
comparison inside the if-statement.
Diff from jdk9 hs-comp hotspot:
(See attached file: hotspot_jdk9_hscomp.diff)
Best regards,
--
Michihiro Horie,
IBM Research - Tokyo
Inactive hide details for "Doerr, Martin" ---2016/05/31 19:18:19---Hello
everybody, I have created a new bug: JDK-8158232"Doerr, Martin"
---2016/05/31 19:18:19---Hello everybody, I have created a new bug:
JDK-8158232
From: "Doerr, Martin" <martin.doerr at sap.com>
To: Gustavo Romero <gromero at linux.vnet.ibm.com>, Michihiro
Horie/Japan/IBM at IBMJP, Miki M Enoki/Japan/IBM at IBMJP
Cc: Breno Leitao <brenohl at br.ibm.com>, "hotspot-dev at openjdk.java.net" <
hotspot-dev at openjdk.java.net>, "ppc-aix-port-dev at openjdk.java.net" <
ppc-aix-port-dev at openjdk.java.net>, "Simonis, Volker" <
volker.simonis at sap.com>, Volker Simonis <volker.simonis at gmail.com>, "Breno
Leitao" <brenohl at br.ibm.com>
Date: 2016/05/31 19:18
Subject: RE: PPC64 VSX load/store instructions in stubs
Hello everybody,
I have created a new bug: JDK-8158232
We will need a webrev and a request for review mail to hotspot-dev:
"RFR(M): 8158232: PPC64: improve byte, int and long array copy stubs by
using VSX instructions"
Thanks and best regards,
Martin
-----Original Message-----
From: Gustavo Romero [mailto:gromero at linux.vnet.ibm.com]
Sent: Dienstag, 31. Mai 2016 03:50
To: Doerr, Martin <martin.doerr at sap.com>; Michihiro Horie <HORIE at jp.ibm.com
>; Miki M Enoki <ENOMIKI at jp.ibm.com>
Cc: Breno Leitao <brenohl at br.ibm.com>; hotspot-dev at openjdk.java.net;
ppc-aix-port-dev at openjdk.java.net; Simonis, Volker <volker.simonis at sap.com
>; Volker Simonis <volker.simonis at gmail.com>; Breno Leitao <
brenohl at br.ibm.com>
Subject: Re: PPC64 VSX load/store instructions in stubs
Hi Michihiro
Thanks a lot for providing a result summary for byte, short, int, and
long.
Using VSR0, 1, 2, and 3 (instead of the VR registers) will not violate
the ABI, so you can use them as Martin suggested.
Martin, should we use the same BugID (8154156: https://goo.gl/z2eGLi)
for byte, short, int, and long webrevs or open a new one?
Thank you.
Best regards,
Gustavo
On 30-05-2016 06:56, Doerr, Martin wrote:
> Hi Michihiro,
>
> thanks for implementing the VSX versions.
>
> Gustavo's change "8154156: PPC64: improve array copy stubs by using
vector instructions" is pushed into hs-comp.
> Your change needs to get adapted:
>
> - The vm_version and assembler parts are already there.
>
> - Vector-scalar load/store instructions use VectorSRegisters,
now.
>
> The byte and int version look good to me. I think the long version should
be implemented in a similar way: check for has_vsx() is necessary, the
length comparison should be done inside of the block.
>
> Best regards,
> Martin
>
>
> From: Michihiro Horie [mailto:HORIE at jp.ibm.com]
> Sent: Montag, 30. Mai 2016 03:43
> To: Miki M Enoki <ENOMIKI at jp.ibm.com>
> Cc: Breno Leitao <brenohl at br.ibm.com>; Gustavo Romero <
gromero at linux.vnet.ibm.com>; hotspot-dev at openjdk.java.net; Doerr, Martin <
martin.doerr at sap.com>; ppc-aix-port-dev at openjdk.java.net; Simonis, Volker <
volker.simonis at sap.com>; Volker Simonis <volker.simonis at gmail.com>
> Subject: Re: PPC64 VSX load/store instructions in stubs
>
>
> Dear Breno, Gustavo, Voker, and Martin,
> I am a cowoker of Miki.
>
> I implemented VSX disjoint arraycopy functions for byte, int, and long.
Although Miki had implemented VSX disjoint long arraycopy, we found a
couple of bugs so I fixed it. Would you please review them?
>
> Micro benchmarks for byte and int are as follows. (The one for long is
the same as Miki's, which was attached before by Miki)
> (See attached file: ArrayCopyTest_byte.java)(See attached file:
ArrayCopyTest_int.java)
>
> Results are as follows. (For the short result, I used Gustavo's code.)
> (See attached file: result_disjoint-arraycopy_vsx-max.jpg)
>
> Patch for Java8:
> (See attached file: hotspot_jdk8.diff)
>
> Patch for Java9:
> (See attached file: hotspot_jdk9.diff)
>
> Best regards,
> --
> Michihiro Horie,
> IBM Research - Tokyo
>
> [Inactive hide details for Miki M Enoki---2016/05/25 00:15:19---Hi Breno,
Thank you for your reply.]Miki M Enoki---2016/05/25 00:15:19---Hi Breno,
Thank you for your reply.
>
> From: Miki M Enoki/Japan/IBM
> To: Breno Leitao <brenohl at br.ibm.com<mailto:brenohl at br.ibm.com>>
> Cc: Gustavo Romero <gromero at linux.vnet.ibm.com<
mailto:gromero at linux.vnet.ibm.com>>, "hotspot-dev at openjdk.java.net<
mailto:hotspot-dev at openjdk.java.net>" <hotspot-dev at openjdk.java.net<
mailto:hotspot-dev at openjdk.java.net>>, "Doerr, Martin"
<martin.doerr at sap.com<mailto:martin.doerr at sap.com>>,
"ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net
>" <ppc-aix-port-dev at openjdk.java.net<
mailto:ppc-aix-port-dev at openjdk.java.net>>, "Simonis, Volker"
<volker.simonis at sap.com<mailto:volker.simonis at sap.com>>, Volker Simonis
<volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>>
> Date: 2016/05/25 00:15
> Subject: Re: PPC64 VSX load/store instructions in stubs
>
> ________________________________
>
>
> Hi Breno,
>
> Thank you for your reply.
>
>> The same mechanism could be used to copy arrays of short elements, as
Gustavo was
>> working on. Do you agree?
>
> I think the mechanism is different with type (byte, short, int, long...).
> Gustavo will apply a pach with VSX for short array copy, so it would be
reasonable to use VSX instruction for long array copy, too.
>
> My coworker is also creating byte and int arraycopy with VSX. He will
post an email to this mailing list.
> I appreciate it if our patch for byte, int and long copy is applied to
OpenJDK.
>
>
> Best regards,
> Miki
>
>
>
>
> [Inactive hide details for Breno Leitao ---2016/05/17 02:29:32---Hi Miki,
On 05/16/2016 02:53 AM, Miki M Enoki wrote:]Breno Leitao ---2016/05/17
02:29:32---Hi Miki, On 05/16/2016 02:53 AM, Miki M Enoki wrote:
>
> From: Breno Leitao <brenohl at br.ibm.com<mailto:brenohl at br.ibm.com>>
> To: Miki M Enoki/Japan/IBM at IBMJP, "Doerr, Martin" <martin.doerr at sap.com<
mailto:martin.doerr at sap.com>>,
> Cc: Gustavo Romero <gromero at linux.vnet.ibm.com<
mailto:gromero at linux.vnet.ibm.com>>, Volker Simonis
<volker.simonis at gmail.com<mailto:volker.simonis at gmail.com>>, "Simonis,
Volker" <volker.simonis at sap.com<mailto:volker.simonis at sap.com>>,
"ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net
>" <ppc-aix-port-dev at openjdk.java.net<
mailto:ppc-aix-port-dev at openjdk.java.net>>, "hotspot-dev at openjdk.java.net<
mailto:hotspot-dev at openjdk.java.net>" <hotspot-dev at openjdk.java.net<
mailto:hotspot-dev at openjdk.java.net>>
> Date: 2016/05/17 02:29
> Subject: Re: PPC64 VSX load/store instructions in stubs
> ________________________________
>
>
>
> Hi Miki,
>
> On 05/16/2016 02:53 AM, Miki M Enoki wrote:
>> I also implemented VSX disjoint long arraycopy.
>> I appreciate it if it is applied to OpenJDK, too.
>
> Thanks for the summarized information, this is helpful. Based on your
plot, I
> understand we can split the whole scenario in two:
>
> * Array size smaller than 4k, and then use VSX instructions to perform
copy
> * Array size bigger than 4k, and then use VMX instructions to perform
copy
>
> The same mechanism could be used to copy arrays of short elements, as
Gustavo was
> working on. Do you agree?
>
> That said, I understand that a new patch should be generated that
contemplates
> both cases on a single patch, ready to be applied on OpenJDK 9 source
code. Hence
> a webrev should be generated mapping to bug id
> https://bugs.openjdk.java.net/browse/JDK-8154156
>
> If you need any help on the webrev[1] creation and hosting, Gustavo might
help,
> since he did this process already.
>
> [1] http://openjdk.java.net/guide/webrevHelp.html
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20160601/5f397e63/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20160601/5f397e63/graycol-0001.gif>
More information about the ppc-aix-port-dev
mailing list