[10] RFR(S): 8185969: PPC64: Improve VSR support to use up to 64 registers

[Gustavo Romero]

Hi Martin,

On 09-08-2017 11:54, Doerr, Martin wrote:
> I think that the new and old version of mtvrd are equivalent. The new one uses to_vsr() and a new version of vsrt() = vsrs() which sets bit 31. I don't see any advantages or disadvantages of using one or the other.
> Am I missing anything?

Ah, I see. opp_u_field((x & 0x20) >> 5, 31, 31) in vsrt()/vsrs() is extracting
the bit 31 according to the operand. mtvrd()/mfvrd() cannot access VSR0-31, but
that's correct. And for a future implementation of mtvsrd/mfvsrd - if needed -
it's just a matter of using `vsrt(d)` instead of `vsrt(d->to_vsr())`, as the
other VSX instructions do now.

OK. Thanks.


Best regards,
Gustavo