RFR [jdk8] : 8193807 : AIX: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad

[Evans, Martin]

Many thanks guys, I look forward to testing.

Regards,

Martin

-----Original Message-----
From: Volker Simonis [mailto:volker.simonis at gmail.com]
Sent: 20 December 2017 09:33
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: jdk8u-dev-request at openjdk.java.net; core-libs-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; Simonis, Volker <volker.simonis at sap.com>; Evans, Martin <Martin.Evans at kingfisher.com>; build-dev <build-dev at openjdk.java.net>
Subject: Re: RFR [jdk8] : 8193807 : AIX: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad

Hi Matthias,

the change looks good!
I can sponsor it once we get the approval.

Also forwarded to buil-dev for the minimal build change.

Thank you and best regards,
Volker


On Wed, Dec 20, 2017 at 9:50 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> Hello  , Mark reported  this issue on AIX  with OpenJDK8 :
>
>>
>>I'm getting an unsatisfied link error when using logstash on AIX but I suspect the issue is with AIX or the JRE, the exception is:
>>
>> java.lang.UnsatisfiedLinkError: sun.management.OperatingSystemImpl.getProcessCpuLoad()D
>>                  getProcessCpuLoad at sun/management/OperatingSystemImpl.java:-2
>>                             <init> at org/logstash/instrument/monitors/ProcessMonitor.java:40
>>                             detect at org/logstash/instrument/monitors/ProcessMonitor.java:79
>>                           generate at
>> org/logstash/instrument/reports/ProcessReport.java:15
>>
>> this is the line in logstash:
>>
>> this.cpuProcessPercent =
>> scaleLoadToPercent(unixOsBean.getProcessCpuLoad());
>>
>> https://github.com/elastic/logstash/blob/master/logstash-core/src/mai
>> n/java/org/logstash/instrument/monitors/ProcessMonitor.java
>>
>>
>> Could anybody help steer me in the right direction?
>>
>
> This fix addresses  the missing  getSystemCpuLoad and getProcessCpuLoad  on AIX  .
> JDK8 is only affected , JDK9 and higher is not affected .
>
> Could I get a  review for this change   ?
>
>
> Change :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8193807/
>
> Bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8193807
>
>
> Thanks, Matthias
------------ Kingfisher plc Registered Office: 3 Sheldon Square, Paddington, London W2 6PX Registered in England, Number 1664812 This e-mail is only intended for the person(s) to whom it is addressed and may contain confidential information. Unless stated to the contrary, any opinions or comments are personal to the writer and do not represent the official view of the company. If you have received this e-mail in error, please notify us immediately by reply e-mail and then delete this message from your system. Please do not copy it or use it for any purpose, or disclose its contents to any other person. Thank you for your co-operation.