RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles

[Doerr, Martin]

Hi Kim,

I have factored out resolve_jobject on PPC64 and s390.

Complete webrev is here:
http://cr.openjdk.java.net/~mdoerr/8166188_s390_ppc64/webrev.06/

Incremental patch (based on webrev.05):
http://cr.openjdk.java.net/~mdoerr/8166188_s390_ppc64/webrev.06/8166188_s390_ppc64_incr.patch

I prefer masking out the weak tag and only checking it if G1 is used. (The additional check and branch is only needed for G1. Also, see new PPC64 and s390 implementation.)
What is preferable on x86? Btw. the indentation looks inconsistent in resolve_jobject.

Best regards,
Martin


-----Original Message-----
From: s390x-port-dev [mailto:s390x-port-dev-bounces at openjdk.java.net] On Behalf Of Kim Barrett
Sent: Montag, 13. Februar 2017 05:26
To: hotspot-dev developers <hotspot-dev at openjdk.java.net>
Cc: s390x-port-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
Subject: Re: RFR: 8166188: G1 Needs pre barrier on dereference of weak JNI handles

Here's the updated webrevs, incorporating feedback received so far.

full: http://cr.openjdk.java.net/~kbarrett/8166188/hotspot.05/
incr: http://cr.openjdk.java.net/~kbarrett/8166188/hotspot.05.inc/

For x86 and ARM I added resolve_jobject functions to their respective
macroAssembler files, and call those to generate the return object
handling code.  Merging the two cases for Sparc is harder and I'm
going to leave it to someone else.  I'm also leaving any such merging
for other (non-Oracle) ports to their respective maintainers.

Rewrote the error checking in SignatureChekker::check_obj to simplify
the control flow and provide more information.  Rather than
conditionally selecting between ReportJNIFatalError or assert to
report problems, instead just always use guarantee.  Recall that we
only get here if CheckJNICalls or in a debug build.  This made
SignatureChekker::_thread unused, so removed it.