8179527: Ineffective use of volatile hurts performance of Charset.atBugLevel()

[Kazunori Ogata]

Hi Christoph,

Thank you for your help.  I'll change the tests and update weberv.


> remove the second run with -Dsun.nio.cs.bugLevel=1.4

How can I do this?  Is it sufficient to remove the following line at the 
beginning of the file?: "@run main/othervm -Dsun.nio.cs.bugLevel=1.4 
EmptyCharsetName"


> PS: The bug is https://bugs.openjdk.java.net/browse/JDK-8182743, not 
> 8179527, as the Subject indicates.

Oops, I'm sorry.  It was the number that my colleague opened before...


Regards,
Ogata


"Langer, Christoph" <christoph.langer at sap.com> wrote on 2017/06/28 
18:23:43:

> From: "Langer, Christoph" <christoph.langer at sap.com>
> To: Alan Bateman <Alan.Bateman at oracle.com>, Kazunori Ogata 
<OGATAK at jp.ibm.com>
> Cc: "ppc-aix-port-dev at openjdk.java.net" <ppc-aix-port-
> dev at openjdk.java.net>, Claes Redestad <claes.redestad at oracle.com>, core-
> libs-dev <core-libs-dev at openjdk.java.net>, "nio-dev at openjdk.java.net" 
> <nio-dev at openjdk.java.net>
> Date: 2017/06/28 18:24
> Subject: RE: 8179527: Ineffective use of volatile hurts performance of 
> Charset.atBugLevel()
> 
> Hi,
> 
> I just filed the CSR: https://bugs.openjdk.java.net/browse/JDK-8183116. 
I 
> set it to status "Proposed". I assume it will be handled by the csr 
group 
> automatically?
> 
> As for the patch: I just recognized that we'll need to update the tests 
> jdk/test/java/nio/charset/Charset/EmptyCharsetName.java and 
jdk/test/java/
> nio/charset/CharsetDecoder/AverageMax.java if we remove 
> "sun.nio.cs.bugLevel". E.g. remove the second run with -
> Dsun.nio.cs.bugLevel=1.4 and clean the code for that. @Ogata: Can you 
> please do that? You might chose to wait until the CSR process is done...
> 
> Best regards
> Christoph
> 
> PS: The bug is https://bugs.openjdk.java.net/browse/JDK-8182743, not 
> 8179527, as the Subject indicates.
> 
> 
> > -----Original Message-----
> > From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
> > Sent: Mittwoch, 28. Juni 2017 11:00
> > To: Langer, Christoph <christoph.langer at sap.com>; Kazunori Ogata
> > <OGATAK at jp.ibm.com>
> > Cc: ppc-aix-port-dev at openjdk.java.net; Claes Redestad
> > <claes.redestad at oracle.com>; core-libs-dev <core-libs-
> > dev at openjdk.java.net>; nio-dev at openjdk.java.net
> > Subject: Re: 8179527: Ineffective use of volatile hurts performance of
> > Charset.atBugLevel()
> > 
> > 
> > 
> > On 27/06/2017 19:32, Langer, Christoph wrote:
> > > :
> > >
> > > @Alan: Do we need a CSR ("Compatibility & Specification Review") 
request
> > here since support for "sun.nio.cs.bugLevel" will be removed?
> > >
> > This system property pre-dates OpenJDK but it would have had a CCC at
> > the time. So creating a CSR to indicate that it can no longer be used 
to
> > get to JDK 1.4 behavior would be good. Thanks.
> > 
> > -Alan