8179527: Ineffective use of volatile hurts performance of Charset.atBugLevel()

Kazunori Ogata OGATAK at jp.ibm.com
Thu Jun 29 18:49:18 UTC 2017


Hi Christoph,

I updated webrev: http://cr.openjdk.java.net/~horii/8179527/webrev.02/

This one includes changes in tests.  I removed all @run and @build 
directives in the tests because those after removing "@run main/othervm 
-Dsun.nio.cs.bugLevel=1.4 EmptyCharsetName" are the same as the default 
ones.  I checked the modified tests passed.

I also fixed the copyright lines.


Regards,
Ogata


"Langer, Christoph" <christoph.langer at sap.com> wrote on 2017/06/28 
21:04:36:

> From: "Langer, Christoph" <christoph.langer at sap.com>
> To: Kazunori Ogata <OGATAK at jp.ibm.com>
> Cc: Alan Bateman <Alan.Bateman at oracle.com>, Claes Redestad 
> <claes.redestad at oracle.com>, core-libs-dev <core-libs-
> dev at openjdk.java.net>, "nio-dev at openjdk.java.net" <nio-
> dev at openjdk.java.net>, "ppc-aix-port-dev at openjdk.java.net" 
<ppc-aix-port-
> dev at openjdk.java.net>
> Date: 2017/06/28 21:04
> Subject: RE: 8179527: Ineffective use of volatile hurts performance of 
> Charset.atBugLevel()
> 
> Hi Ogata,
> 
> > > remove the second run with -Dsun.nio.cs.bugLevel=1.4
> > 
> > How can I do this?  Is it sufficient to remove the following line at 
the
> > beginning of the file?: "@run main/othervm -Dsun.nio.cs.bugLevel=1.4
> > EmptyCharsetName"
> 
> Yes, this line should be removed. Currently there are two @run 
directives 
> which cause running the testcase twice. Once in normal mode and once 
with 
> bugLevel set to 1.4. So, if "sun.nio.cs.bugLevel" ought to be removed 
then
> the second iteration of the test is obsolete. And then one should 
probably
> remove the whole "compat" handling in the test.
> 
> Best regards
> Christoph
> 




More information about the ppc-aix-port-dev mailing list