RFR(S): 8191770: [ppc64] Fix CDS: don't rewrite invokefinal if DumpSharedSpaces

[Volker Simonis]

Thanks Martin!


On Mon, Nov 27, 2017 at 5:05 PM, Doerr, Martin <martin.doerr at sap.com> wrote:
> Hi Volker,
>
> looks good. Thanks for fixing.
>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of Volker Simonis
> Sent: Montag, 27. November 2017 16:55
> To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
> Cc: ppc-aix-port-dev at openjdk.java.net
> Subject: RFR(S): 8191770: [ppc64] Fix CDS: don't rewrite invokefinal if DumpSharedSpaces
>
> Hi,
>
> can I please have a review for the following small, ppc64-only change
> which fixes CDS on Power:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2017/8191770/
> https://bugs.openjdk.java.net/browse/JDK-8191770
>
> Don't rewrite invokefinal into fast_invokevfinal if running with
> DumpSharedSpaces or UseSharedSpaces.
>
> The Template-Interpreter of the ppc-Port was initially derived from
> the SPARC version which didn't had full CDS support at that time,
> that's why the guard against DumpSharedSpaces was missing at the place
> where invokefinal is rewritten.
>
> With this change, all the CDS and upcoming AppCDS jtreg pass on
> Linux/ppc64, Linux/ppc64le and AIX.
>
> Thank you and best regards,
> Volker