RFR:8188802:PPC64: Failure on assert(lrgmask.is_aligned_sets(RegMask::SlotsPerVecX))

[Michihiro Horie]

Hi Martin,

Thanks a lot for fixing switches with "SuperwordUseVSX" and pushing the
change.

Best regards,
--
Michihiro,
IBM Research - Tokyo



From:	"Doerr, Martin" <martin.doerr at sap.com>
To:	Michihiro Horie <HORIE at jp.ibm.com>,
            "ppc-aix-port-dev at openjdk.java.net"
            <ppc-aix-port-dev at openjdk.java.net>,
            "hotspot-dev at openjdk.java.net" <hotspot-dev at openjdk.java.net>
Cc:	Hiroshi H Horii <HORII at jp.ibm.com>, Gustavo Romero
            <gromero at linux.vnet.ibm.com>, Kazunori Ogata
            <OGATAK at jp.ibm.com>
Date:	2017/10/05 20:05
Subject:	RE: RFR:8188802:PPC64: Failure on assert
            (lrgmask.is_aligned_sets(RegMask::SlotsPerVecX))



Hi Michihiro,

pushed this change as it enables us to build and run the VM again.
I have introduced a switch “SuperwordUseVSX” which I only enable on
>=Power8. Reason is that you’re using Power8 instructions which broke the
VM for older processors.

Regards,
Martin


From: Michihiro Horie [mailto:HORIE at jp.ibm.com]
Sent: Donnerstag, 5. Oktober 2017 11:16
To: ppc-aix-port-dev at openjdk.java.net; hotspot-dev at openjdk.java.net; Doerr,
Martin <martin.doerr at sap.com>
Cc: Hiroshi H Horii <HORII at jp.ibm.com>; Gustavo Romero
<gromero at linux.vnet.ibm.com>; Kazunori Ogata <OGATAK at jp.ibm.com>
Subject: RFR:8188802:PPC64: Failure on assert(lrgmask.is_aligned_sets
(RegMask::SlotsPerVecX))



Dear all,

Would you please review the following change?
Bug: https://bugs.openjdk.java.net/browse/JDK-8188802
Webrev: http://cr.openjdk.java.net/~mhorie/8188802/webrev.00/

This change fixes the assertion failures, which occur after introducing
"8188139:PPC64: Superword Level Parallelization with VSX".
I exchanged the order of declarations of alloc_classes for SR and VSR.
After this fix, another assertion in rc_class() in ppc.ad failed, I
modified the assertion itself to take into account newly added VSRs.

I would be happy to revise code if these changes do not make sense.

Best regards,
--
Michihiro,
IBM Research - Tokyo


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20171006/ca071ca8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20171006/ca071ca8/graycol.gif>