RFR(S): 8196565: AIX: Clean up os::javaTimeNanos according to AIX/PASE specification

[Langer, Christoph]

Hi Matthias,

thanks for looking at this.

I updated my coding (webrev in place) to add back the assertion and I also updated the CAS coding to the one that's used on other platforms such as Solaris and BSD/MacOS.

Best regards
Christoph

From: Baesken, Matthias
Sent: Donnerstag, 1. Februar 2018 10:27
To: Langer, Christoph <christoph.langer at sap.com>; hotspot-runtime-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
Subject: RE: RFR(S): 8196565: AIX: Clean up os::javaTimeNanos according to AIX/PASE specification

Hi Christoph,  maybe it would be better to check  the return code of  time_base_to_time,  the doc at

https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.basetrf2/read_real_time.htm


says : "The time_base_to_time subroutine returns 0 if the conversion to real time is successful (or not necessary), otherwise -1 is returned."

So errors might (at least in theory) occur .


(otherwise it looks good to me, not  a Reviewer however)

Best regards, Matthias



From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of Langer, Christoph
Sent: Donnerstag, 1. Februar 2018 10:11
To: hotspot-runtime-dev at openjdk.java.net<mailto:hotspot-runtime-dev at openjdk.java.net>; ppc-aix-port-dev at openjdk.java.net<mailto:ppc-aix-port-dev at openjdk.java.net>
Subject: RFR(S): 8196565: AIX: Clean up os::javaTimeNanos according to AIX/PASE specification

Hi,

please review a fix for the os::javaTimeNanos method on AIX.

It implements the information we got from the AIX documentation and from the IBM folks regarding the behavior of mread_real_time on Pase.

Bug: https://bugs.openjdk.java.net/browse/JDK-8196565
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196565.0/

Thanks & Best regards
Christoph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20180201/3addc907/attachment-0001.html>