RFR(XS) JDK10: 8196678: avoid printing uninitialized buffer in os::print_memory_info on AIX

[Langer, Christoph]

Thanks, David.

Embarassing...I meant %.2f. Updated in place.

Best regards
Christoph

-----Original Message-----
From: David Holmes [mailto:david.holmes at oracle.com] 
Sent: Freitag, 2. Februar 2018 14:20
To: Langer, Christoph <christoph.langer at sap.com>; hotspot-runtime-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
Subject: Re: RFR(XS) JDK10: 8196678: avoid printing uninitialized buffer in os::print_memory_info on AIX

On 2/02/2018 10:46 PM, Langer, Christoph wrote:
> Hi again,
> 
> Here is an updated webrev where we also corrected a wrong format specifier:
> http://cr.openjdk.java.net/~clanger/webrevs/8196678.1/

!       st->print_cr("%% system asp used : %.2s",
           mi.pgsp_total ? (100.0f * (mi.pgsp_total - mi.pgsp_free) / 
mi.pgsp_total) : -1.0f);

%s for a floating-point value ??

David

> Thanks
> Christoph
> 
> From: Langer, Christoph
> Sent: Freitag, 2. Februar 2018 13:36
> To: hotspot-runtime-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
> Cc: Zeller, Arno <arno.zeller at sap.com>
> Subject: RFR(XS) JDK10: 8196678: avoid printing uninitialized buffer in os::print_memory_info on AIX
> 
> Hi,
> 
> Arno has spotted an issue when printing hs_err files on AIX. This fix should still be done for JDK10. Please review and approve.
> 
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196678.0/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8196678
> 
> Thanks
> Christoph
>